This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
CMake: Do not touch CMAKE_GENERATOR_TOOLSET #13321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From documentation: The value of this variable should never be modified by project code. ... changing the value has undefined behavior. * https://cmake.org/cmake/help/latest/variable/CMAKE_GENERATOR_TOOLSET.html
@lebeg could you take a look at this PR? |
@mxnet-label-bot add [pr-awaiting-merge] @ruslo thanks for the contribution! |
@mxnet-label-bot update [pr-awaiting-review] |
marcoabreu
added
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-merge
Review and CI is complete. Ready to Merge
labels
Nov 20, 2018
I'm not sure where is the error.
Network problems? |
The failure is unrelated, I've restarted the build. |
lebeg
approved these changes
Nov 20, 2018
@mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
Review and CI is complete. Ready to Merge
and removed
pr-awaiting-review
PR is waiting for code review
labels
Nov 20, 2018
Thanks for your fixing this. merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From documentation:
Description
Fix CMake configuration error.
Checklist
Essentials