Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

CMake: Do not touch CMAKE_GENERATOR_TOOLSET #13321

Merged
merged 1 commit into from
Nov 21, 2018
Merged

CMake: Do not touch CMAKE_GENERATOR_TOOLSET #13321

merged 1 commit into from
Nov 21, 2018

Conversation

ruslo
Copy link
Contributor

@ruslo ruslo commented Nov 19, 2018

From documentation:

The value of this variable should never be modified by project code.
... changing the value has undefined behavior.

Description

Fix CMake configuration error.

Checklist

Essentials

From documentation:

  The value of this variable should never be modified by project code.
  ... changing the value has undefined behavior.

* https://cmake.org/cmake/help/latest/variable/CMAKE_GENERATOR_TOOLSET.html
@ruslo ruslo requested a review from szha as a code owner November 19, 2018 17:04
@kalyc
Copy link
Contributor

kalyc commented Nov 19, 2018

@lebeg could you take a look at this PR?

@kalyc
Copy link
Contributor

kalyc commented Nov 19, 2018

@mxnet-label-bot add [pr-awaiting-merge]

@ruslo thanks for the contribution!

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Nov 19, 2018
@stu1130
Copy link
Contributor

stu1130 commented Nov 20, 2018

@mxnet-label-bot update [pr-awaiting-review]
@ruslo Could you check with the CI build failure? feel free to ask questions if you need any help!
@larroy @lebeg ping for the review

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-merge Review and CI is complete. Ready to Merge labels Nov 20, 2018
@yajiedesign
Copy link
Contributor

yajiedesign commented Nov 20, 2018

yes.it is useless code.
Maybe I didn't explain it clearly.
Reference #9940
The PR also cleaned up this (#10564), but none of them had been merged.

@ruslo
Copy link
Contributor Author

ruslo commented Nov 20, 2018

Could you check with the CI build failure? feel free to ask questions if you need any help!

I'm not sure where is the error.

Makefile:599: recipe for target 'rpkgtest' failed
make: *** [rpkgtest] Error 1
test_model.R:129: error: Fine-tune
cannot open URL 'http://data.dmlc.ml/models/imagenet/inception-bn/Inception-BN-0126.params'
1: GetInception() at R-package/tests/testthat/test_model.R:129
2: download.file("http://data.dmlc.ml/models/imagenet/inception-bn/Inception-BN-0126.params", 
       destfile = "model/Inception-BN-0126.params")

Network problems?

@lebeg
Copy link
Contributor

lebeg commented Nov 20, 2018

The failure is unrelated, I've restarted the build.

@stu1130
Copy link
Contributor

stu1130 commented Nov 20, 2018

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Nov 20, 2018
@nswamy nswamy merged commit afc4703 into apache:master Nov 21, 2018
@nswamy
Copy link
Member

nswamy commented Nov 21, 2018

Thanks for your fixing this. merged

@ruslo ruslo deleted the pr.cmake branch November 21, 2018 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants