-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Initial website documentation for Java API #13289
Conversation
@mxnet-label-bot add [pr-awaiting-review] |
@andrewfayres thanks for your contribution! Have these instructions been tested locally? |
@@ -0,0 +1,111 @@ | |||
# Setup the MXNet Package for Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a preview link to this in your description:
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-13289/3/install/java_setup.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add new link once build finishes
In addition to my previous comments, let's handle the tutorials main index page and the API navigation in one step.
Let me know if I can assist. |
8a790fd
to
4ab939b
Compare
I think I've addressed all feedback. As soon as the build finishes and we get the preview version I'll update the links and double check everything. |
…or to 1.4.0 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... please review the preview when it finishes though.
6435c26
to
ad551a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewfayres Please confirm this before we merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is the first pass at creating the website documentation needed for the new Java API release.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-13289/10/install/java_setup.html