Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

CudnnFind() usage improvements (v1.3.x) #13123

Merged
merged 14 commits into from
Nov 7, 2018

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Nov 5, 2018

Description

A port of #12804 to the v1.3.x release branch.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lebeg
Copy link
Contributor Author

lebeg commented Nov 5, 2018

Should MXGetGPUMemoryInformation64 be left out of the perl interface in perl-package/AI-MXNetCAPI/mxnet.i? The function was not there before in the 1.3.0 release.

@lebeg
Copy link
Contributor Author

lebeg commented Nov 5, 2018

@DickJC123 @nswamy

@DickJC123
Copy link
Contributor

Happy to let PERL users decide. The thinking was that the existing 32-bit MXGetGPUMemoryInformation interface was broken, and generally unavailable to users except for the PERL interface. Rather than have the bug fix change the size of the method's arguments, a faux pas with semantic versioning, a new method name was introduced. I wanted a working routine, made available via Python, for use in a new Python unittest I introduced. PERL users that don't have this unittest might opt for not adding to their API in 1.3.x.

@anirudhacharya
Copy link
Member

anirudhacharya commented Nov 5, 2018

@mxnet-label-bot [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Nov 6, 2018
Copy link
Contributor

@sergeykolychev sergeykolychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@szha szha merged commit a94109a into apache:v1.3.x Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants