-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Julia v0.7/1.0 support and drop v0.6 support #12845
Conversation
@iblis17 Thanks for this contribution. |
@iblis17 Could you please update the PR description and check into the CI failure and change the title when the PR is good to be reviewed. |
yeah, will do that. but this PR isn't ready. |
@iblis17 Thanks for the amazing contribution |
yeah, still WIP. (i'm just quite busy this week.) |
@mxnet-label-bot add [pr-work-in-progress] |
and drop v0.6 support
Ready for review. |
@mxnet-label-bot update [julia, pr-awaiting-review] |
I'm going to merge it this weekend if no objection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
One minor thing where I'd like to get Aarons opinion one, but from CI side is everything good to go.
I just found that the main doc build is deployed to an aws site. |
The CI failures are unrelated. |
@iblis17 Hi there - I was just tracing where the julia docs end up... and it seems that they are made but are not deployed anywhere yet... or am I missing a step that picks up outside of the CI process? |
@aaronmarkham I plan to deploy it in downside channel -- gh-page of MXNet.jl (https://github.com/dmlc/MXNet.jl) Since the syntax needed by Julia is not support by the implementation of sphinx markdown plugin, |
@iblis17 Can you point me to more info about this Sphinx markdown plugin issue? What about getting Julia into the new pipeline and website proposed here? Could it follow the pattern that R using now? Or do we still have some plugin issue to deal with? |
@aaronmarkham well, I have tried to integrate it ... several month ago, but ran into markdown parsing failure. |
TODO:
new broadcast mechanism
fix
@nd_as_jl
Add CI build for Julia 0.7
Add CI build for Julia 1.0
maybe another PR for docs.