Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Julia v0.7/1.0 support and drop v0.6 support #12845

Merged
merged 111 commits into from
Jan 14, 2019
Merged

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Oct 17, 2018

TODO:

  • new broadcast mechanism

  • fix @nd_as_jl

  • Add CI build for Julia 0.7

  • Add CI build for Julia 1.0

  • maybe another PR for docs.

@Roshrini
Copy link
Member

@iblis17 Thanks for this contribution.
@mxnet-label-bot [pr-work-in-progress]

@ankkhedia
Copy link
Contributor

@iblis17 Could you please update the PR description and check into the CI failure and change the title when the PR is good to be reviewed.

@iblislin
Copy link
Member Author

yeah, will do that. but this PR isn't ready.

@stu1130
Copy link
Contributor

stu1130 commented Nov 21, 2018

@iblis17 Thanks for the amazing contribution
if you need any help, feel free to ask.
Is PR still working in progress?

@iblislin
Copy link
Member Author

yeah, still WIP. (i'm just quite busy this week.)

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Nov 28, 2018
@iblislin iblislin changed the title WIP: Julia v0.7/1.0 support and drop v0.6 support Julia v0.7/1.0 support and drop v0.6 support Jan 2, 2019
@iblislin
Copy link
Member Author

iblislin commented Jan 2, 2019

Ready for review.

@iblislin
Copy link
Member Author

iblislin commented Jan 2, 2019

@mxnet-label-bot update [julia, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Jan 2, 2019
@iblislin
Copy link
Member Author

I'm going to merge it this weekend if no objection.

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

One minor thing where I'd like to get Aarons opinion one, but from CI side is everything good to go.

@iblislin
Copy link
Member Author

iblislin commented Jan 12, 2019

I just found that the main doc build is deployed to an aws site.
Maybe Julia doc can be deployed to that site as well?

@iblislin
Copy link
Member Author

The CI failures are unrelated.

@iblislin iblislin closed this Jan 14, 2019
@iblislin iblislin reopened this Jan 14, 2019
@iblislin iblislin merged commit d22b323 into apache:master Jan 14, 2019
@iblislin iblislin deleted the ib/jl-07 branch January 14, 2019 09:40
@iblislin iblislin mentioned this pull request Jan 28, 2019
@aaronmarkham
Copy link
Contributor

@iblis17 Hi there - I was just tracing where the julia docs end up... and it seems that they are made but are not deployed anywhere yet... or am I missing a step that picks up outside of the CI process?

@iblislin
Copy link
Member Author

@aaronmarkham I plan to deploy it in downside channel -- gh-page of MXNet.jl (https://github.com/dmlc/MXNet.jl)

Since the syntax needed by Julia is not support by the implementation of sphinx markdown plugin,
it's hard to integrate with current MXNet doc system.

@aaronmarkham
Copy link
Contributor

@iblis17 Can you point me to more info about this Sphinx markdown plugin issue?

What about getting Julia into the new pipeline and website proposed here?
#14330

Could it follow the pattern that R using now? Or do we still have some plugin issue to deal with?

@iblislin
Copy link
Member Author

@aaronmarkham well, I have tried to integrate it ... several month ago, but ran into markdown parsing failure.
I can set a experimental branch up, and try to re-produce the failure.

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Julia pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants