This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Backport] Fix for test_ndarray.test_order failing on CI (v1.3.x) #12725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebeg
reviewed
Oct 2, 2018
| @@ -819,9 +831,9 @@ def get_large_matrix(): | |||
| # Repeat those tests that don't involve indices. These should pass even with | |||
| # duplicated input data values (over many repeated runs with different random seeds, | |||
| # this will be tested). | |||
| for dtype in [np.int16, np.int32, np.int64, np.float32, np.float64]: | |||
| for dtype in [ np.int32, np.int64, np.float32, np.float64]: | |||
There was a problem hiding this comment.
You have a formatting glitch - whitespace after opening square bracket
|
You have a typo in the title ;) I suggest for the title: |
ankkhedia
changed the title
lebeg
approved these changes
Oct 2, 2018
|
@ankkhedia strange, I see your commit, but not the fix in the main diff. |
|
@mxnet-label-bot [pr-awaiting-merge] |
|
@mxnet-label-bot [pr-awaiting-testing] |
marcoabreu
added
pr-awaiting-merge
|
@lebeg Could you please take a look now. So, there were two places with that formatting glitch, one was fixed while other was looked over in previous commit. |
|
@lebeg ping! |
lebeg
approved these changes
Oct 8, 2018
|
@sandeep-krishnamurthy Could you please review and merge this PR if it looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting fix for flaky test: test_ndarray.test_order from master as the test failed in CI. Tracked in #12310
The test uses np.int16 which is not a supported dtype for ndarray.
Also, conversion of np array to ndarray defaults to float32 in destination ndarray even though the dtype of source could be anything leading to failure of unites due to loss of precision in some cases.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
--> Removed tests for np.int16
--> Instead of using default dtype for converting arrays , used the type from source array to convert to target array.