Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix the location of the tutorial of control flow operators. #12638

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

zheng-da
Copy link
Contributor

Description

The tutorial of control flow operators are placed under Module API, but it's actually written for Gluon.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@zheng-da zheng-da requested a review from szha as a code owner September 21, 2018 23:40
@stu1130
Copy link
Contributor

stu1130 commented Sep 22, 2018

Thanks for your contribution @zheng-da
@mxnet-label-bot[pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 22, 2018
@vandanavk
Copy link
Contributor

@aaronmarkham for review

@vandanavk
Copy link
Contributor

@sandeep-krishnamurthy Please change the label to pr-awaiting-merge

@sandeep-krishnamurthy sandeep-krishnamurthy removed the pr-awaiting-review PR is waiting for code review label Sep 25, 2018
@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 4236b98 into apache:master Sep 25, 2018
@zheng-da zheng-da deleted the update_doc branch December 9, 2018 01:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants