This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix version dropdown behavior #12632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @aaronmarkham |
|
This is super important ux improvement, thanks for following it up and fixing it. |
gigasquid
approved these changes
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bad behavior of the versions dropdown on the website. It will remember what API document you were viewing when you switch versions. It even remembers which anchor/bookmark you're on.
Preview
You can play with it here: http://34.201.8.176/
This is how it works on the site now. You're in deep on some doc page, and then think, "I wonder if the params are different in the last release...". You click the versions dropdown, select 1.3.0, and then bam, you're taken to the 1.3.0 home page.
This is so annoying. Now you have to go and search for that page again.
With this PR, changing versions does what you'd expect it to do!
If you pick a doc that didn't exist in a previous version, you get a 404 error.
