Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNet-970] improve tutorial redirection #12607

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

aaronmarkham
Copy link
Contributor

Description

This PR improves the tutorial redirects. It takes the request for an old version tutorial and maps the request back to the default version of the website with the document request intact.
Prior to my #12540 update, users would land on untested, broken tutorials. However, I found it less than ideal that a request to an old tutorial wouldn't just take you to the latest one. This PR does just that.

Say a user googles image prediction with mxnet and gets this result:
http://34.201.8.176/versions/0.11.0/tutorials/python/predict_image.html
Before, they'd get to it and if they were on Windows, it wouldn't work. This was fixed a couple of months ago.

With my recent update, they redirect to the tutorials index which was better than going to a broken tutorial, but with this update they just redirect the latest version of the tutorial:
http://34.201.8.176/tutorials/python/predict_image.html

Say a user finds an old google result or link to this old LSTM tutorial that's been deleted: http://34.201.8.176/versions/0.11.0/tutorials/speech_recognition/speech_lstm.html
We'll give them a 404.

Thanks goes to @ddavydenko for guiding me on the frustrating journey of regexes.
https://regex101.com/ FTW! ✨

@stu1130
Copy link
Contributor

stu1130 commented Sep 20, 2018

Thanks for your contribution @aaronmarkham
@mxnet-label-bot[pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Sep 20, 2018
@indhub indhub merged commit ba993d1 into apache:master Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants