Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update docs to list cmake required for build from source page #12592

Merged
merged 2 commits into from
Sep 21, 2018
Merged

update docs to list cmake required for build from source page #12592

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5a98f
update doc to list cmake as required
azai91 Sep 18, 2018
f29a34f
update docs to list cmake required only for mkldnn build
azai91 Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/install/build_from_source.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ This document explains how to build MXNet from source code. Building MXNet from

You need C++ build tools and a BLAS library to build the MXNet shared library. If you want to run MXNet with GPUs, you will need to install [NVDIA CUDA and cuDNN](https://developer.nvidia.com/cuda-downloads) first.

You may use [GNU Make](https://www.gnu.org/software/make/) to build the library but [cmake](https://cmake.org/) is required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate why cmake is required? I am building from source just fine with config.mk and make

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when building with make with the MKLDNN, cmake it required: https://github.com/apache/incubator-mxnet/blob/master/mkldnn.mk#L40.

additionally there two discussions already to remove the makefile and make cmake default

https://lists.apache.org/[email protected]:2018-6:cmake
#8702

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for GNU make, we can continue stay with MKLDNN=0 regardless of final discussion result. Anyways, I think it should help some users to skip those compiling tools in certain circumstances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the purpose of the vote was to eliminate the Makefile. if you think we should keep the Makefile, raise it in the email list. otherwise the direction we are heading is removing it completely and becoming dependent on cmake.



### C++ build tools

Expand All @@ -25,7 +27,7 @@ You need C++ build tools and a BLAS library to build the MXNet shared library. I

2. [Git](https://git-scm.com/downloads) for downloading the sources from Github repository.

3. [cmake](https://cmake.org/) is recommended. You may also use [GNU Make](https://www.gnu.org/software/make/) to build the library.



### BLAS library
Expand Down