Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-968] Fix MacOS python tests #12590

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Sep 18, 2018

Description

Fixes: #12089
MacOS python tests are failing. This seems to be because OpenCV on brew is missing some threading symbols that we're calling. As a work around I'm reverting to a previously working behaviour (not setting threading limits explicitly on MacOS builds).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Testing Done

Tested locally and with TravisCI on a prior commit. Tests pass correctly.

Fixes: apache#12089
MacOS python tests are failing.  This seems to be because OpenCV on
brew is missing some threading symbols that we're calling.  As a work
around I'm reverting to a previously working behaviour (not setting
threading limits explicitly on MacOS builds).
@marcoabreu marcoabreu merged commit 1744b0c into apache:master Sep 18, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Fixes: apache#12089
MacOS python tests are failing.  This seems to be because OpenCV on
brew is missing some threading symbols that we're calling.  As a work
around I'm reverting to a previously working behaviour (not setting
threading limits explicitly on MacOS builds).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unittest fail on MacOS platform
2 participants