Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Make Gluon download function to be atomic #12572

Merged
merged 38 commits into from
Oct 12, 2018
Merged

Make Gluon download function to be atomic #12572

merged 38 commits into from
Oct 12, 2018

Commits on Sep 14, 2018

  1. use rename trick to achieve atomic write but didn't support python2 a… 

    …nd windows
    @stu1130
    stu1130 committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    b7fc61d View commit details
    Browse the repository at this point in the history

  2. add test for multiprocess download

    @stu1130
    stu1130 committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    657a921 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2018

  1. implement atomic_replace referred by https://github.com/untitaker/pyt… 

    …hon-atomicwrites
    @stu1130
    stu1130 committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    353221a View commit details
    Browse the repository at this point in the history

  2. change the number of testing process to 10

    @stu1130
    stu1130 committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    32ff8cd View commit details
    Browse the repository at this point in the history

  3. add docstring and disable linter

    @stu1130
    stu1130 committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    7ded536 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. half way to address some issue reviewer have

    @stu1130
    stu1130 committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    b4c6b1f View commit details
    Browse the repository at this point in the history

  2. use warning instead of raise UserWarn

    @stu1130
    stu1130 committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    901ed34 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    a9d40c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. check for sha1

    @stu1130
    stu1130 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    91f9ca9 View commit details
    Browse the repository at this point in the history

  2. Trigger CI

    @stu1130
    stu1130 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    9ab6341 View commit details
    Browse the repository at this point in the history

  3. fix the logic of checking hash

    @stu1130
    stu1130 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    1985726 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    429684a View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. refine the error message

    @stu1130
    stu1130 committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    df2a9ef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    602b7d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. add more comments and expose the error message to the user

    @stu1130
    stu1130 committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    3bed37c View commit details
    Browse the repository at this point in the history

  2. delete trailing whitespace

    @stu1130
    stu1130 committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    f0b8c5d View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2018

  1. rename _path_to_encode to _str_to_unicode

    @stu1130
    stu1130 committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    47f65c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2018

  1. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    85f9408 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    5a01234 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    8f58746 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. fix the error message bug and add remove when the movefile fail on wi… 

    …ndows
    @stu1130
    stu1130 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    b4235f0 View commit details
    Browse the repository at this point in the history

  2. add remove temp file for non-windows os

    @stu1130
    stu1130 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    f0776b9 View commit details
    Browse the repository at this point in the history

  3. handle the OSError caused by os.remove

    @stu1130
    stu1130 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    c7756df View commit details
    Browse the repository at this point in the history

  4. Trigger CI

    @stu1130
    stu1130 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    971ecf9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    1531594 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix_race_condion_download

    @stu1130
    stu1130 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    4dec67c View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    3e799de View commit details
    Browse the repository at this point in the history

  2. use finally to raise failure of atomic replace

    @stu1130
    stu1130 committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    af5b8ec View commit details
    Browse the repository at this point in the history

  3. Merge commit '5314cf4742767319ce356bd5154c6885380e0d5c' into fix_race… 

    …_condion_download
    @stu1130
    stu1130 committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    25e21b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    f690c69 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix_race_condion_download

    @stu1130
    stu1130 committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    0212e5a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. add missing try except block for os.remove

    @stu1130
    stu1130 committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    6af8945 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    a091a97 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. add retries value to error message

    @stu1130
    stu1130 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    6765862 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    f1359be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_race_condion_download

    @stu1130
    stu1130 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    a7b7b12 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/apache/incubator-mxnet

    @stu1130
    stu1130 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    e360853 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_race_condion_download

    @stu1130
    stu1130 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    3662d38 View commit details
    Browse the repository at this point in the history