This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
review require() usages to add meaningful messages. #12570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @mdespriee |
|
@mdespriee thanks a lot for taking the time to improve the messages. there are a few scalastyle errors, could you please fix them, test locally(at least the unit tests) and then push. I can merge the code later |
mdespriee
force-pushed
the
improve_error_msg
branch
from
82dfeb8
to
2790d7d
Compare
mdespriee
changed the title
|
Removing [WIP]. The failing test is probably a flaky test (clojure). |
|
@mdespriee please fix this line: You should be able to pass them afterwards |
|
Mostly just commenting so I can easily watch this but I really like this improvement! |
|
@lanking520 fixed. Any existing JIRA to mention ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation of this PR is to add & improve error messages raised by failed requirements.
In relation to #12565.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
No feature change.
Comment
Unfortunately, i'm not sure to really improve the error messages regarding shape inference. Real improvement would come from backend error messages. Any suggestions ?