This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix error in try/finally block for blc #12561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebeg
reviewed
Sep 14, 2018
| @@ -32,10 +32,8 @@ core_logic: { | |||
| node(NODE_LINUX_CPU) { | |||
| ws('workspace/brokenLinkChecker') { | |||
| timeout(time: 60, unit: 'MINUTES') { | |||
| try { | |||
| utils.init_git() | |||
| utils.docker_run('ubuntu_blc', 'broken_link_checker', false) | |||
There was a problem hiding this comment.
Hm, shouldn't we catch and log here instead?
There was a problem hiding this comment.
@lebeg - Added the catch block.
lebeg
approved these changes
Sep 14, 2018
|
Thanks for your contribution @sandeep-krishnamurthy |
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
* Fix error in try/finally block for blc * Add catch block for BLC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue introduced in this PR - #12507 for broken link checker.
"finally" block was removed because regression checks were removed. but, I had missed to remove "try" block.
Fails with this error - http://jenkins.mxnet-ci.amazon-ml.com/job/Broken_Link_Checker_Pipeline/310/console
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
@lebeg