Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add license headers to R-package #12559

Merged
merged 2 commits into from
Sep 15, 2018

Conversation

anirudhacharya
Copy link
Member

Description

Add license headers to all files in R-package.

Current MXNet release instructions requires all files in the R-package to be removed until licensing issues are resolved, before we build the tar file. This PR is to resolve those licensing issues.

Comments

Copy link
Contributor

@lupesko lupesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the licensing issue!

@lupesko
Copy link
Contributor

lupesko commented Sep 14, 2018

@anirudhacharya The R-Package folder also contains a LICENSE file, which is not an Apache2.0 license. How are we addressing it?

@lupesko
Copy link
Contributor

lupesko commented Sep 14, 2018

@mxnet-label-bot [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 14, 2018
@sandeep-krishnamurthy
Copy link
Contributor

Thanks @anirudhacharya
Please add Apache 2.0 license header to all examples under demo/
We need to update the R-Package LICENSE file as well

@sandeep-krishnamurthy sandeep-krishnamurthy added R pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Sep 14, 2018
@ankkhedia
Copy link
Contributor

ankkhedia commented Sep 14, 2018

@anirudhacharya The R-Package folder also contains a LICENSE file, which is not an Apache2.0 license. How are we addressing it?

Should we just remove that license and after adding Apache license to every file.

@anirudhacharya
Copy link
Member Author

@ankkhedia why should we remove the file? scala, clojure and cpp package also have LICENSE files.

@ankkhedia
Copy link
Contributor

ankkhedia commented Sep 14, 2018

@ankkhedia why should we remove the file? scala, clojure and cpp package also have LICENSE files.

But python don't have. I don't mind it having over there just that if adding headers to all the files suffices do we need an extra file?
Maybe @lupesko and @sandeep-krishnamurthy can comment on it.

@sandeep-krishnamurthy
Copy link
Contributor

@ankkhedia - I do not have a strong opinion but it is good to have in the base package folder.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 6f93b03 into apache:master Sep 15, 2018
@anirudhacharya anirudhacharya deleted the license branch September 15, 2018 06:36
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* add license headers to R-package

* license file and demos folder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-response PR is reviewed and waiting for contributor to respond R
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants