Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix lazy record io when used with dataloader and multi_worker > 0 #12554

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

zhreshold
Copy link
Member

Description

Fixes multi_worker data loader when record file is used. The MXRecordIO instance needs to require a new file handler after fork to be safely manipulated simultaneously.

This fix also safely voids the previous temporary fixes #12093 #11370.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zhreshold zhreshold changed the title Fix lazy record mp Fix lazy record io when used with dataloader and multi_worker > 0 Sep 13, 2018
@zhreshold
Copy link
Member Author

@szha

@szha szha merged commit 52116d4 into apache:master Sep 13, 2018
@zhreshold zhreshold deleted the fix-lazy-record-mp branch September 13, 2018 22:24
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
…ache#12554)

* temp solution to record file dataset with multi worker

* fix cascaded dataset for gluon dataloader, when multi_worker > 0 is used
@zhreshold zhreshold mentioned this pull request Oct 1, 2018
3 tasks
lebeg pushed a commit to lebeg/incubator-mxnet that referenced this pull request Nov 5, 2018
…ache#12554)

* temp solution to record file dataset with multi worker

* fix cascaded dataset for gluon dataloader, when multi_worker > 0 is used
szha pushed a commit that referenced this pull request Nov 7, 2018
…2554) (#13124)

* temp solution to record file dataset with multi worker

* fix cascaded dataset for gluon dataloader, when multi_worker > 0 is used
eric-haibin-lin pushed a commit to eric-haibin-lin/mxnet that referenced this pull request Nov 20, 2018
…ache#12554)

* temp solution to record file dataset with multi worker

* fix cascaded dataset for gluon dataloader, when multi_worker > 0 is used
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants