Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-950] Enable parallel R dep builds in CI #12552

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

KellenSunderland
Copy link
Contributor

Description

This PR should speedup R builds in CI by enabling parallel compilation of dependencies.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu marcoabreu changed the title [MXNET-950] Enable parallel python dep builds in CI [MXNET-950] Enable parallel R dep builds in CI Sep 13, 2018
@@ -739,6 +739,9 @@ unittest_ubuntu_gpu_cpp() {
unittest_ubuntu_cpu_R() {
set -ex
mkdir -p /tmp/r-site-library
# build R packages in parallel
mkdir -p ~/.R/
echo "MAKEFLAGS = -j72" > ~/.R/Makevars
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is during runtime, we can us nproc instead of hardcoding the number of jobs

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the hardcoded number of jobs

@KellenSunderland
Copy link
Contributor Author

Yeah, that's a good point. Will update

@marcoabreu marcoabreu merged commit 0b91230 into apache:master Sep 13, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* [MXNET-950] Enable parallel python dep builds in CI

* [MXNET-950] parallelize by availible cores
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants