Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-908] Enable python tests in Travis #12550

Merged
merged 1 commit into from
Sep 19, 2018
+3 −2
Merged

[MXNET-908] Enable python tests in Travis #12550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ script:
- export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0
- mv make/osx.mk config.mk
- make -j 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KellenSunderland instead of placing python here as a job that travis would always execute, could you please put python build section into a separate target so we can also add Scala-maven test in here in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly this will help: https://docs.travis-ci.com/user/build-stages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if we could add Scala tests as well, but I do have a few concerns. How long would they take to execute? Let's keep in mind that we have a limited number of executors that can be run before we begin interfering with other Apache projects. There's also a global timeout of ~45 minutes to build and execute on a virtualized MacOS host which takes a few minutes just to start. I'd ideally like to keep our total test time below 30 minutes to avoid hitting this in the future.

In principle I'm not against build stages, but unless we have a lot of jobs running in parallel that have dependencies on each other I don't see a big benefit in using them.

Copy link
Member

@lanking520 lanking520 Sep 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply! If you mean scalaunittestit will be around 10 mins or less. Is travis wait possible to apply in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately Travis wait won't help in this case. The tests are active and sending output to Travis, they just take a long time and hit the global timeout for Travis jobs.

10 minutes actually is reasonable. Let's do a test run with Scala enabled after this is merged and see if we can get it included. My guess is if we enable folder caching, and cache models we're currently downloading we'll be able to fit it in and not hit the global timeouts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's try to make Scala test available later in Travis.

- python -m nose --verbose tests/python/unittest/
4 changes: 2 additions & 2 deletions ci/travis/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ if [ ${TRAVIS_OS_NAME} == "osx" ]; then
brew install libpng
brew install ImageMagick
brew install swig
python -m pip install --user nose numpy cython scipy requests
python3 -m pip install --user nose numpy cython scipy requests
python -m pip install --user nose numpy cython scipy requests mock
python3 -m pip install --user nose numpy cython scipy requests mock
fi