This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Implement mkldnn convolution fusion and quantization. #12530
Merged
Merged
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
9d08a1c
Implement mkldnn convolution fusion.
ZhennanQin 9134b4d
Fix lint
ZhennanQin 34af229
Fix performance regression caused by mkldnn fallback.
ZhennanQin 8d5ef03
Merge remote-tracking branch 'upstream/master' into mkldnn_fusion_int8
ZhennanQin affb564
clean up include
ZhennanQin 5729b96
Fix msbuild on openmp pragma.
ZhennanQin 81e8e28
Fix quantization test, allow to use original op names as exclude laye…
ZhennanQin a245bc3
Fix unittest.
ZhennanQin ff2a3c2
Fix unittest
ZhennanQin 013bb0d
fix lint
ZhennanQin 3eee14d
Add post quantize fusion
ZhennanQin 8322784
add test case
huangzhiyuan 302fa65
add head license in test case
huangzhiyuan efc7f1e
Remove GetBoolHash()
ZhennanQin 741c221
Remove mkldnn fallback change.
ZhennanQin 05e595a
Address Haibin's comments.
ZhennanQin 3f24d97
Add TIsMKLDNN for _sg_mkldnn_conv temporarily.
ZhennanQin 146e157
Address reminisce's comments.
ZhennanQin 966839d
Handle the case that inplace fail.
ZhennanQin 9ccc4bd
pass unit test.
ZhennanQin 136676c
Merge branch 'master' into mkldnn_fusion_int8
ZhennanQin b00c09e
Add symbol api get_backend_symbol()
ZhennanQin 3b7f4f7
Retrigger ci
ZhennanQin 97d1841
update the test case
huangzhiyuan b009f13
Check subgraph index.
ZhennanQin 813610c
Use index as FAvoidQuantizeInput's parameter.
ZhennanQin 8833a02
Add mkldnn_hwigo support as quantizaiton needs.
ZhennanQin f89bd28
Address KellenSunderland's comments.
ZhennanQin 5034946
Merge remote-tracking branch 'upstream/master' into mkldnn_fusion_int8
rongzha1 c5bf05d
Handle input order change after subgraph pass.
ZhennanQin 8da56c8
Fix ci test
ZhennanQin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,207 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
import argparse | ||
import os | ||
import logging | ||
from common import modelzoo | ||
import mxnet as mx | ||
from mxnet.contrib.quantization import * | ||
from mxnet.base import SymbolHandle, check_call, _LIB, mx_uint, c_str_array | ||
import ctypes | ||
|
||
|
||
def download_calib_dataset(dataset_url, calib_dataset, logger=None): | ||
if logger is not None: | ||
logger.info('Downloading calibration dataset from %s to %s' % (dataset_url, calib_dataset)) | ||
mx.test_utils.download(dataset_url, calib_dataset) | ||
|
||
|
||
def download_model(model_name, logger=None): | ||
dir_path = os.path.dirname(os.path.realpath(__file__)) | ||
model_path = os.path.join(dir_path, 'model') | ||
if logger is not None: | ||
logger.info('Downloading model %s... into path %s' % (model_name, model_path)) | ||
return modelzoo.download_model(args.model, os.path.join(dir_path, 'model')) | ||
|
||
|
||
def save_symbol(fname, sym, logger=None): | ||
if logger is not None: | ||
logger.info('Saving symbol into file at %s' % fname) | ||
sym.save(fname) | ||
|
||
|
||
def save_params(fname, arg_params, aux_params, logger=None): | ||
if logger is not None: | ||
logger.info('Saving params into file at %s' % fname) | ||
save_dict = {('arg:%s' % k): v.as_in_context(cpu()) for k, v in arg_params.items()} | ||
save_dict.update({('aux:%s' % k): v.as_in_context(cpu()) for k, v in aux_params.items()}) | ||
mx.nd.save(fname, save_dict) | ||
|
||
|
||
if __name__ == '__main__': | ||
parser = argparse.ArgumentParser(description='Generate a calibrated quantized model from a FP32 model with MKL-DNN support') | ||
parser.add_argument('--model', type=str, choices=['imagenet1k-resnet-152', 'imagenet1k-inception-bn'], | ||
help='currently only supports imagenet1k-resnet-152 or imagenet1k-inception-bn') | ||
parser.add_argument('--batch-size', type=int, default=32) | ||
parser.add_argument('--label-name', type=str, default='softmax_label') | ||
parser.add_argument('--calib-dataset', type=str, default='data/val_256_q90.rec', | ||
help='path of the calibration dataset') | ||
parser.add_argument('--image-shape', type=str, default='3,224,224') | ||
parser.add_argument('--data-nthreads', type=int, default=60, | ||
help='number of threads for data decoding') | ||
parser.add_argument('--num-calib-batches', type=int, default=10, | ||
help='number of batches for calibration') | ||
parser.add_argument('--exclude-first-conv', action='store_true', default=True, | ||
help='excluding quantizing the first conv layer since the' | ||
' input data may have negative value which doesn\'t support at moment' ) | ||
parser.add_argument('--shuffle-dataset', action='store_true', default=True, | ||
help='shuffle the calibration dataset') | ||
parser.add_argument('--shuffle-chunk-seed', type=int, default=3982304, | ||
help='shuffling chunk seed, see' | ||
' https://mxnet.incubator.apache.org/api/python/io/io.html?highlight=imager#mxnet.io.ImageRecordIter' | ||
' for more details') | ||
parser.add_argument('--shuffle-seed', type=int, default=48564309, | ||
help='shuffling seed, see' | ||
' https://mxnet.incubator.apache.org/api/python/io/io.html?highlight=imager#mxnet.io.ImageRecordIter' | ||
' for more details') | ||
parser.add_argument('--calib-mode', type=str, default='entropy', | ||
help='calibration mode used for generating calibration table for the quantized symbol; supports' | ||
' 1. none: no calibration will be used. The thresholds for quantization will be calculated' | ||
' on the fly. This will result in inference speed slowdown and loss of accuracy' | ||
' in general.' | ||
' 2. naive: simply take min and max values of layer outputs as thresholds for' | ||
' quantization. In general, the inference accuracy worsens with more examples used in' | ||
' calibration. It is recommended to use `entropy` mode as it produces more accurate' | ||
' inference results.' | ||
' 3. entropy: calculate KL divergence of the fp32 output and quantized output for optimal' | ||
' thresholds. This mode is expected to produce the best inference accuracy of all three' | ||
' kinds of quantized models if the calibration dataset is representative enough of the' | ||
' inference dataset.') | ||
parser.add_argument('--quantized-dtype', type=str, default='uint8', | ||
choices=['int8', 'uint8'], | ||
help='quantization destination data type for input data') | ||
parser.add_argument('--enable-calib-quantize', type=bool, default=True, | ||
help='If enabled, the quantize op will ' | ||
'be calibrated offline if calibration mode is ' | ||
'enabled') | ||
args = parser.parse_args() | ||
ctx = mx.cpu(0) | ||
logging.basicConfig() | ||
logger = logging.getLogger('logger') | ||
logger.setLevel(logging.INFO) | ||
|
||
logger.info('shuffle_dataset=%s' % args.shuffle_dataset) | ||
|
||
calib_mode = args.calib_mode | ||
logger.info('calibration mode set to %s' % calib_mode) | ||
|
||
# download calibration dataset | ||
if calib_mode != 'none': | ||
download_calib_dataset('http://data.mxnet.io/data/val_256_q90.rec', args.calib_dataset) | ||
|
||
# download model | ||
prefix, epoch = download_model(model_name=args.model, logger=logger) | ||
sym, arg_params, aux_params = mx.model.load_checkpoint(prefix, epoch) | ||
|
||
sym = sym.get_backend_symbol('MKLDNN') | ||
|
||
# get batch size | ||
batch_size = args.batch_size | ||
logger.info('batch size = %d for calibration' % batch_size) | ||
|
||
# get number of batches for calibration | ||
num_calib_batches = args.num_calib_batches | ||
if calib_mode == 'none': | ||
logger.info('skip calibration step as calib_mode is none') | ||
else: | ||
logger.info('number of batches = %d for calibration' % num_calib_batches) | ||
|
||
# get number of threads for decoding the dataset | ||
data_nthreads = args.data_nthreads | ||
|
||
# get image shape | ||
image_shape = args.image_shape | ||
|
||
exclude_first_conv = args.exclude_first_conv | ||
excluded_sym_names = [] | ||
if args.model == 'imagenet1k-resnet-152': | ||
rgb_mean = '0,0,0' | ||
calib_layer = lambda name: name.endswith('_output') | ||
excluded_sym_names += ['flatten0', 'fc1'] | ||
if exclude_first_conv: | ||
excluded_sym_names += ['conv0', 'pooling0'] | ||
elif args.model == 'imagenet1k-inception-bn': | ||
rgb_mean = '123.68,116.779,103.939' | ||
calib_layer = lambda name: name.endswith('_output') | ||
excluded_sym_names += ['flatten', 'fc1'] | ||
if exclude_first_conv: | ||
excluded_sym_names += ['conv_1'] | ||
else: | ||
raise ValueError('model %s is not supported in this script' % args.model) | ||
|
||
label_name = args.label_name | ||
logger.info('label_name = %s' % label_name) | ||
|
||
data_shape = tuple([int(i) for i in image_shape.split(',')]) | ||
logger.info('Input data shape = %s' % str(data_shape)) | ||
|
||
logger.info('rgb_mean = %s' % rgb_mean) | ||
rgb_mean = [float(i) for i in rgb_mean.split(',')] | ||
mean_args = {'mean_r': rgb_mean[0], 'mean_g': rgb_mean[1], 'mean_b': rgb_mean[2]} | ||
|
||
if calib_mode == 'none': | ||
logger.info('Quantizing FP32 model %s' % args.model) | ||
qsym, qarg_params, aux_params = quantize_model(sym=sym, arg_params=arg_params, aux_params=aux_params, | ||
ctx=ctx, excluded_sym_names=excluded_sym_names, | ||
calib_mode=calib_mode, quantized_dtype=args.quantized_dtype, | ||
logger=logger) | ||
sym_name = '%s-symbol.json' % (prefix + '-quantized') | ||
else: | ||
logger.info('Creating ImageRecordIter for reading calibration dataset') | ||
data = mx.io.ImageRecordIter(path_imgrec=args.calib_dataset, | ||
label_width=1, | ||
preprocess_threads=data_nthreads, | ||
batch_size=batch_size, | ||
data_shape=data_shape, | ||
label_name=label_name, | ||
rand_crop=False, | ||
rand_mirror=False, | ||
shuffle=args.shuffle_dataset, | ||
shuffle_chunk_seed=args.shuffle_chunk_seed, | ||
seed=args.shuffle_seed, | ||
**mean_args) | ||
|
||
qsym, qarg_params, aux_params = quantize_model(sym=sym, arg_params=arg_params, aux_params=aux_params, | ||
ctx=ctx, excluded_sym_names=excluded_sym_names, | ||
calib_mode=calib_mode, calib_data=data, | ||
num_calib_examples=num_calib_batches * batch_size, | ||
calib_layer=calib_layer, quantized_dtype=args.quantized_dtype, | ||
label_names=(label_name,), calib_quantize_op = True, | ||
logger=logger) | ||
if calib_mode == 'entropy': | ||
suffix = '-quantized-%dbatches-entropy' % num_calib_batches | ||
elif calib_mode == 'naive': | ||
suffix = '-quantized-%dbatches-naive' % num_calib_batches | ||
else: | ||
raise ValueError('unknow calibration mode %s received, only supports `none`, `naive`, and `entropy`' | ||
% calib_mode) | ||
sym_name = '%s-symbol.json' % (prefix + suffix) | ||
qsym = qsym.get_backend_symbol('MKLDNN_POST_QUANTIZE') | ||
save_symbol(sym_name, qsym, logger) | ||
param_name = '%s-%04d.params' % (prefix + '-quantized', epoch) | ||
save_params(param_name, qarg_params, aux_params, logger) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1542,18 +1542,17 @@ MXNET_DLL int MXSymbolInferType(SymbolHandle sym, | |
* \param sym_handle symbol to be converted | ||
* \param ret_sym_handle quantized symbol result | ||
* \param num_excluded_symbols number of layers excluded from being quantized in the input symbol | ||
* \param excluded_symbols array of symbols to be excluded from being quantized | ||
* \param excluded_symbols op names to be excluded from being quantized | ||
* \param num_offline number of parameters that are quantized offline | ||
* \param offline_params array of c strings representing the names of params quantized offline | ||
* \param quantized_dtype the quantized destination type for input data. | ||
* \param calib_quantize whether calibrate quantize op with offline calibration data. | ||
*/ | ||
MXNET_DLL int MXQuantizeSymbol(SymbolHandle sym_handle, | ||
SymbolHandle *ret_sym_handle, | ||
MXNET_DLL int MXQuantizeSymbol(SymbolHandle sym_handle, SymbolHandle *ret_sym_handle, | ||
const mx_uint num_excluded_symbols, | ||
const SymbolHandle *excluded_symbols, | ||
const mx_uint num_offline, | ||
const char **offline_params, | ||
const char *quantized_dtype); | ||
const char **excluded_symbols, | ||
const mx_uint num_offline, const char **offline_params, | ||
const char *quantized_dtype, const bool calib_quantize); | ||
|
||
/*! | ||
* \brief Set calibration table to node attributes in the sym | ||
|
@@ -1571,6 +1570,15 @@ MXNET_DLL int MXSetCalibTableToQuantizedSymbol(SymbolHandle qsym_handle, | |
const float* high_quantiles, | ||
SymbolHandle* ret_sym_handle); | ||
|
||
/*! | ||
* \brief Run subgraph pass based on the backend provided | ||
* \param sym_handle symbol to be converted | ||
* \param backend backend names for subgraph pass | ||
* \param ret_sym_handle returned symbol | ||
*/ | ||
MXNET_DLL int MXGenBackendSubgraph(SymbolHandle sym_handle, const char *backend, | ||
SymbolHandle *ret_sym_handle); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this CAPI provided? It seems it's only used in testing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not for testing, but for quantization script. For mkldnn quantization, we agreed to do fusion first, and then do quantization. So on python side, we need an api to generate fused graph, and then pass it to quantization pass. Otherwise, we have to allow simple_bind returning the graph after subgraph pass. |
||
//-------------------------------------------- | ||
// Part 4: Executor interface | ||
//-------------------------------------------- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could update readme.md with an example to run this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do want to provide resnet50v1 as example, but we don't know where's to put the pre-trained model and its parameter file. Do you have any suggestion where's to upload them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eric-haibin-lin it's a good idea. The quantization feature is improved a lot with this PR and we need a clear README. @xinyu-intel please draft a README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, could we upload our model/parameters into http://data.mxnet.io/data/ so that the end user could reproduce the INT8 performance and accuracy w/o training the model again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an apache mxnet s3 bucket. @szha can help you with that