This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix website render issue on < and > #12482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep-krishnamurthy
approved these changes
Sep 8, 2018
|
@piiswrong - You authored it earlier, can you please suggest if this will not break other expected behavior? |
sandeep-krishnamurthy
added
the
pr-awaiting-merge
|
Merging this PR, as it fixes couple of issues and I couldn't hear back from Eric. Verified on the rendered site, did not find any issues. |
aaronmarkham
added a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Sep 11, 2018
aaronmarkham
added a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Sep 11, 2018
indhub
pushed a commit
that referenced
this pull request
Sep 12, 2018
* consistent theme plus error handling for missing apis and pages * add error pages * update messaging * force url update to 404 page on redirect * static redirect to force url update * version dropdown fix; reverts #12482; lesser of evils * adding note to nudge past flakey test
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
* consistent theme plus error handling for missing apis and pages * add error pages * update messaging * force url update to 404 page on redirect * static redirect to force url update * version dropdown fix; reverts apache#12482; lesser of evils * adding note to nudge past flakey test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12168
Fixes #11438
Comments
I didn't hear back yet from @piiswrong about the purpose of this particular line. However, removing it fixes two documented render issues, and I don't see any negative effects after removing the line.
Preview
http://34.201.8.176/versions/tag_render/