Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] Fix race-conditon download function #12466

Closed
wants to merge 8 commits into from

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Sep 5, 2018

Description

Originally download function within gluon/utils.py would cause race-condition(#11646).
The PR tackle the problem by giving the downloaded file a tempory name and renaming back to target filename.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Assign a uuid for the downloaded file and rename back to the target filename
  • Add corresponding unittests to check the correctness within multiprocesses

Comments

N/A

@stu1130 stu1130 requested a review from szha as a code owner September 5, 2018 23:13
@stu1130 stu1130 closed this Sep 14, 2018
@stu1130 stu1130 deleted the fix_download branch September 14, 2018 00:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant