Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-908] Enable minimal OSX Travis build #12462

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

KellenSunderland
Copy link
Contributor

Description

This PR removes some legacy Travis code, and updates Travis to run cached MXNet builds on the platform. It is the first step in re-enabling MacOS testing. Subsequent PRs will enable testing (which will rely on builds first being cached). Subsequent PRs can also re-enable some of the features removed in this PR, for instance possible running more tests in addition to python tests, and re-enabling the model-download caching folder.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

#slack: dmlc:NmroCzntCiWOuxUZpii40USd
- export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0
- mv make/osx.mk config.mk
- make -j 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the variable not available in Travis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to the magic '2' here, good point, I don't specify why that's required. I've updated with a comment that should provide some background.

@marcoabreu marcoabreu added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Sep 5, 2018
@KellenSunderland
Copy link
Contributor Author

@KellenSunderland
Copy link
Contributor Author

@mxnet-label-bot can please add [pr-awaiting-review]

@marcoabreu marcoabreu merged commit 28cb75a into apache:master Sep 5, 2018
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
KellenSunderland added a commit to KellenSunderland/incubator-mxnet that referenced this pull request Sep 15, 2018
KellenSunderland added a commit to KellenSunderland/incubator-mxnet that referenced this pull request Sep 15, 2018
KellenSunderland added a commit to KellenSunderland/incubator-mxnet that referenced this pull request Sep 15, 2018
KellenSunderland added a commit to KellenSunderland/incubator-mxnet that referenced this pull request Sep 15, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants