Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adjust tolerance levels of test_l2_normalization #12429

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Sep 1, 2018

Description

Fix #12417.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Adjust tolerance level for test_operator.test_l2_normalization
  • Get rid of unnecessary in-line comments.

Comments

@haojin2
Copy link
Contributor Author

haojin2 commented Sep 3, 2018

@marcoabreu @larroy @lebeg Please take a look when you have time, thanks!

@marcoabreu marcoabreu merged commit d00cb42 into apache:master Sep 3, 2018
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_operator.test_l2_normalization failure in CI
3 participants