Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-878] Add trigonometric operators to onnx #12424

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Aug 31, 2018

Description

Adding trigonometric operators to ONNX export

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added 6 operators in mx2onnx/_op_translations.py
  • Added tests for the 6 operators in onnx_backend_test.py

Comments

@Roshrini

@vandanavk vandanavk requested a review from szha as a code owner August 31, 2018 16:14
@Roshrini
Copy link
Member

LGTM :)

Copy link
Member

@anirudhacharya anirudhacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

for review - @zhreshold

@szha szha changed the title Add trigonometric operators Add trigonometric operators to onnx Aug 31, 2018
@szha szha removed their request for review August 31, 2018 17:53
@vandanavk vandanavk changed the title Add trigonometric operators to onnx [MXNET-878] Add trigonometric operators to onnx Aug 31, 2018
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vandanavk !

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 307e62a into apache:master Sep 3, 2018
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants