This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fixed docs/website build checkout bug #12413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
reviewed
Aug 31, 2018
| @@ -14,7 +14,7 @@ r_docs = 0 | |||
| scala_docs = 1 | |||
|
|
|||
| [document_sets_v1.2.0] | |||
There was a problem hiding this comment.
I see two copies of document_sets_1.2.0. Is that intended?
There was a problem hiding this comment.
Aaron explained offline that for each version one entry is for release branch while the other is for release tag. Currently, the pipeline is set up so that docs are built from branches.
aaronmarkham
added a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Sep 11, 2018
* fixed checkout bug; fixed echo statement * turning off clojure docs for v1.2.0
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
* fixed checkout bug; fixed echo statement * turning off clojure docs for v1.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the docs build pipeline where a failover case didn't checkout a different branch as expected. This caused master API docs to appear in older versions in CI. Local builds would run fine.
Added a hard error stop on the checkout step to prevent any issue like this popping up silently in CI.
Also fixed the echo statement to print exactly what should be run next.
Also removed Clojure from the v1.2.0 settings for docs generation. These should only generate in master or in 1.3.0+.
For example, in the CI logs:
It checks if the branch is there already, if not it grabs it from upstream. What is missing here is that it also needed to checkout the newly created branch. If all fails then the process aborts on this step, rather than continue with master.
Comments
The consistent theme is patched in a separate PR: #12426.