Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-860] Update to modern nullptr usage #12352

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Aug 25, 2018

Description

This PR changes a few NULL assignments to the more specific C++11 nullptr.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@KellenSunderland KellenSunderland changed the title [MXNET-860] Update to modern nullptr usage WIP - [MXNET-860] Update to modern nullptr usage Aug 25, 2018
@KellenSunderland KellenSunderland force-pushed the nullptr_update branch 4 times, most recently from 1c138b3 to 7925409 Compare August 25, 2018 16:17
@KellenSunderland KellenSunderland changed the title WIP - [MXNET-860] Update to modern nullptr usage [MXNET-860] Update to modern nullptr usage Sep 2, 2018
@KellenSunderland
Copy link
Contributor Author

@mxnet-label-bot can please add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 5, 2018
@KellenSunderland KellenSunderland force-pushed the nullptr_update branch 2 times, most recently from a7ca93a to 3777f33 Compare September 9, 2018 17:00
@marcoabreu marcoabreu added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Sep 18, 2018
@marcoabreu
Copy link
Contributor

Please resolve the conflict

@KellenSunderland
Copy link
Contributor Author

@marcoabreu Rebased and ready to go.

@marcoabreu
Copy link
Contributor

Another conflict :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants