This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
A solution to prevent zombie containers locally and in CI #12336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
LGTM, let's get the host AMIs changed. |
lebeg
approved these changes
Aug 27, 2018
marcoabreu
approved these changes
Aug 27, 2018
I was hoping to see some usage info. 1) how to make a zombie; 2) how to kill it - I'd be happy to test this out. |
I added info in the readme. Do you see it in the patch? |
larroy
force-pushed
the
zombies_singled
branch
from
August 28, 2018 13:08
da7db7e
to
499b73b
Compare
KellenSunderland
suggested changes
Aug 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run pylint and mypy on this commit again, I see some issues.
Done. I don't know why the PR is not updated. |
any ideas? is a github problem? |
larroy
requested review from
cjolivier01,
sergeykolychev,
szha,
thirdwing and
yzhliu
as code owners
August 28, 2018 15:40
I can't reopen the PR, had some troubles with PR not updating and Jenkins, new pR: |
Github is having issues today. https://status.github.com/messages |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds mechanisms on the build scripts to cleanup docker containers when there is a cancellation, either from the user by sending SIGINT / SIGTERM or when the process inside the container ends with an error.
It also propagates the environment variables from Jenkins which are used by the process tree killer to identify runaway processes so processes inside the container are killed when the Jenkins job is stopped.
With this patch we catch SIGINT and SIGTERM and install a handler on atexit which cleans (stops) docker containers which were created during execution of the build.
We also switch to python docker API for better management of running containers.
@aaronmarkham @marcoabreu @lebeg @KellenSunderland
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.