Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Temporarily disable ARMv7 builds #12260

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Temporarily disable ARMv7 builds #12260

merged 1 commit into from
Aug 20, 2018

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Aug 20, 2018 •
edited
Loading

Description

Temporarily disable ARMv7 builds

This PR temporarily disables ARMv7 builds. These builds seem to be braking based on a recent dependency change. We'll address the broken dependency, but as an interim solution I recommend disabling the build.

Mitigates: #12258

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • Note: I noticed a similar issue earlier in the day with another build locally. I'm wondering if we might see more of these after caches expire. It would be great if others could test local builds.

larroy
larroy suggested changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@larroy larroy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

larroy
larroy reviewed Aug 20, 2018
View reviewed changes
Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@KellenSunderland KellenSunderland mentioned this pull request Aug 20, 2018
Closed
@haojin2
Copy link
Contributor

haojin2 commented Aug 20, 2018

@anirudh2290 @marcoabreu @nswamy @sandeep-krishnamurthy Please help merging this PR ASAP when you have time! Thanks!

@nswamy nswamy merged commit a4aced7 into apache:master Aug 20, 2018
KellenSunderland added a commit to KellenSunderland/incubator-mxnet that referenced this pull request Aug 21, 2018
@KellenSunderland
Revert "Temporarily disable ARMv7 builds (apache#12260)"
330da6e 
This reverts commit a4aced7.
KellenSunderland added a commit to KellenSunderland/incubator-mxnet that referenced this pull request Aug 21, 2018
@KellenSunderland
Revert "Temporarily disable ARMv7 builds (apache#12260)"
4b5fbf0 
This reverts commit a4aced7.
marcoabreu pushed a commit that referenced this pull request Aug 23, 2018
@KellenSunderland @lebeg @marcoabreu
[MXNET-849] - Enable armv7 with pinned docker images. (#12272)
e1b2265 
* Revert "Temporarily disable ARMv7 builds (#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <[email protected]>
Roshrini pushed a commit to Roshrini/mxnet that referenced this pull request Aug 24, 2018
@KellenSunderland @lebeg @Roshrini
[MXNET-849] - Enable armv7 with pinned docker images. (apache#12272)
2173b3a 
* Revert "Temporarily disable ARMv7 builds (apache#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <[email protected]>
szha pushed a commit that referenced this pull request Aug 24, 2018
@Roshrini @szha
Release1.3 cherry-pick few PRs (#12338)
d343276 
* Fix a bug in where op with 1-D input (#12325)

* Fix a bug in where op with 1-D input

* Add unit test

* [MXNET-849] - Enable armv7 with pinned docker images. (#12272)

* Revert "Temporarily disable ARMv7 builds (#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <[email protected]>

* [MXNET-855] Update clang to version 6 (#12305)
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@KellenSunderland @nswamy
Temporarily disable ARMv7 builds (apache#12260)
98e0af0
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@KellenSunderland @lebeg @marcoabreu
[MXNET-849] - Enable armv7 with pinned docker images. (apache#12272)
7d9febd 
* Revert "Temporarily disable ARMv7 builds (apache#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <[email protected]>
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@KellenSunderland @anirudh2290
Temporarily disable ARMv7 builds (apache#12260)
24597a1
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@KellenSunderland @lebeg @anirudh2290
[MXNET-849] - Enable armv7 with pinned docker images. (apache#12272)
67f7348 
* Revert "Temporarily disable ARMv7 builds (apache#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@larroy larroy larroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KellenSunderland @haojin2 @larroy @marcoabreu @nswamy