Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-696] Simplify the logic behind the reload(mxnet) test #12188

Merged
merged 3 commits into from
Aug 17, 2018
Merged

[MXNET-696] Simplify the logic behind the reload(mxnet) test #12188

merged 3 commits into from
Aug 17, 2018

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 15, 2018

Description

Simplify the logic behind the reload(mxnet) test

Implements Python porting best practice use feature detection instead of version detection.

flake8 testing of https://github.com/apache/incubator-mxnet on Python 3.7.0

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./tests/python/unittest/test_engine_import.py:33:13: F821 undefined name 'reload'
            reload(mxnet)
            ^

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Simplify the logic behind the reload(mxnet) test

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!
LGTM.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 30f6c39 into apache:master Aug 17, 2018
@cclauss cclauss deleted the patch-1 branch August 17, 2018 16:27
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
…12188)

* Simplify the logic behind the reload(mxnet) test

* Force a retest

* Remove trailing whitespace
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants