Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Added comment to docs regarding ToTensor transform #12186

Merged
merged 6 commits into from
Sep 18, 2018
Merged

Added comment to docs regarding ToTensor transform #12186

merged 6 commits into from
Sep 18, 2018

Conversation

thomelane
Copy link
Contributor

Description

Added note in documentation regarding order of transforms.
User mentioned this in #10906.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes): tiny change!
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage: N/A
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added comment to docs

thomelane and others added 4 commits July 25, 2018 11:51
@thomelane
Corrections to profiling tutorial
c27336d 
Corrected a race condition with stopping profiling. Added mx.nd.waitall to ensure all operations have completed, including GPU operations that might otherwise be missing.

Also added alternative code for context selection GPU vs CPU, that had error before on machines with nvidia-smi.
Merge branch 'master' of https://github.com/thomelane/incubator-mxnet
4f458fd
Merge branch 'master' of https://github.com/apache/incubator-mxnet
87aef6b
Adding note in documentation regarding ToTensor transform.
c382a2f
@thomelane thomelane requested a review from szha as a code owner August 15, 2018 21:38
@thomelane thomelane mentioned this pull request Aug 15, 2018
Closed
@lupesko
Copy link
Contributor

lupesko commented Sep 5, 2018

CI failure seems unrelated (ARMv7 build failure).
@thomelane can you please re-trigger the CI so we have a clean build?

Looping in @piiswrong and @zhreshold for review.

@thomelane
Copy link
Contributor Author

@lupesko just re-triggered, thanks for heads up!

@stu1130
Copy link
Contributor

stu1130 commented Sep 18, 2018

@piiswrong @zhreshold @sandeep-krishnamurthy Could you please take a look at this PR?
@mxnet-label-bot [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 18, 2018
sandeep-krishnamurthy
sandeep-krishnamurthy approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomelane
LGTM

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 5d07a07 into apache:master Sep 18, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@thomelane @anirudh2290
Added comment to docs regarding ToTensor transform (apache#12186)
9a6289b 
* Corrections to profiling tutorial

Corrected a race condition with stopping profiling. Added mx.nd.waitall to ensure all operations have completed, including GPU operations that might otherwise be missing.

Also added alternative code for context selection GPU vs CPU, that had error before on machines with nvidia-smi.

* Adding note in documentation regarding ToTensor transform.

* Removed line to fix lint error.

* Change to start CI build
@thomelane thomelane deleted the docs_transforms branch January 11, 2019 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lupesko lupesko lupesko approved these changes

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomelane @lupesko @stu1130 @sandeep-krishnamurthy @marcoabreu