This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add test to check that binded is not set when exception thrown #12167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep-krishnamurthy
suggested changes
Aug 15, 2018
tests/python/unittest/test_module.py
Outdated
|
|
||
| mod = mx.mod.Module(sym, ('data',), None, context=[mx.cpu(0), mx.cpu(1)]) | ||
| assertRaises(TypeError, mod.bind, data_shapes=[('data', mx.nd.array([10,10]))]) | ||
| mod.binded = False |
There was a problem hiding this comment.
you intended assert mod.binded == False?
tests/python/unittest/test_module.py
Outdated
| mod.binded = False | ||
|
|
||
| mod.bind(data_shapes=[('data', (10,10))]) | ||
| mod.binded = True |
There was a problem hiding this comment.
you intended assert mod.binded == True?
sandeep-krishnamurthy
added
Test
pr-awaiting-response
sandeep-krishnamurthy
approved these changes
Aug 15, 2018
sandeep-krishnamurthy
added
pr-awaiting-testing
piyushghai
added a commit
to piyushghai/incubator-mxnet
that referenced
this pull request
Aug 17, 2018
apache#12167)" This reverts commit f737cac.
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…e#12167) * add test to check binded is not when exception thrown * add error to assertion * fix typo by adding asserts * retrigger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test for the previous PR #12155 that set binded flag after setup complete.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments