Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Edit shape.array doc and some style improvements #12162

Merged
merged 3 commits into from
Aug 29, 2018

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Aug 14, 2018

  • fix grammar in shape.array doc
  • consistent use of <- instead of = for assignment
  • necessary spaces
  • shorten line length

@lupesko
Copy link
Contributor

lupesko commented Aug 28, 2018

Thanks for the contribution @terrytangyuan !
Can you please update the description to be more informative?
Looping in @ankkhedia @anirudhacharya @hetong007 for review.

Copy link
Member

@anirudhacharya anirudhacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan please use formatR - https://yihui.name/formatr/ to indent and structure the code.

@terrytangyuan
Copy link
Member Author

What's the difference? I am just making some enhancements myself manually for this particular file. All the changes are valid here. Others feel free to use formatR themselves for enhancement for the overall package.

@anirudhacharya
Copy link
Member

@terrytangyuan Because we are in the process of having uniform standards for the R-package and eventually have lintR run on the pipeline. For example - #12360

@terrytangyuan
Copy link
Member Author

I believe that should be done in a separate PR. I doubt that formatR gives the most readable code, e.g. I've rarely seen the following style but it appears to be on the PR you referred to:

convolution_module <- function(net, kernel_size, pad_size, filter_count, stride = c(1, 
  1), work_space = 2048, batch_norm = TRUE, down_pool = FALSE, up_pool = FALSE, 

or

if (Sys.getenv("R_GPU_ENABLE") != "" & as.integer(Sys.getenv("R_GPU_ENABLE")) == 
  1) {

Copy link
Member

@anirudhacharya anirudhacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. it should be fine to fix other code formatting issues in a different PR.

@hetong007
Copy link
Contributor

@terrytangyuan You can trigger the CI again, with an empty commit by
git commit --allow-empty -m "Trigger CI"

@ankkhedia
Copy link
Contributor

ankkhedia commented Aug 29, 2018

looks good to me!
Should be good to go after you retrigger CI.

@terrytangyuan
Copy link
Member Author

Re-triggered but failed again. Seems like Python tests are failing which is unrelated to this PR.

@terrytangyuan terrytangyuan removed the request for review from thirdwing August 29, 2018 16:24
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Aug 29, 2018

Ok now it finally passed after I retriggered CI twice.

@hetong007 hetong007 merged commit 5af3d39 into master Aug 29, 2018
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch August 29, 2018 22:21
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
* Edit shape.array doc and some style improvements

* Trigger CI

* Trigger CI
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* Edit shape.array doc and some style improvements

* Trigger CI

* Trigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants