This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
site-wide social include #12102
Closed
Closed
site-wide social include #12102
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8660740
trying out site-wide social include
aaronmarkham b266724
adding svg versions of social icons
aaronmarkham e6c533d
fix social section images and layout on contribute
aaronmarkham 382258f
fix max-height for logos on home page
aaronmarkham 295a709
making the twitter birdie bigger
aaronmarkham 99a4738
conformed svg images to single design
aaronmarkham bf0299c
fixup! conformed svg images to single design
aaronmarkham c8ef1bb
fixup! conformed svg images to single design
aaronmarkham fc0f9f4
fixup! fix max-height for logos on home page
aaronmarkham fce65c0
only show social on index page and updated youtube address
aaronmarkham 97248b2
fix splash div overlap on social navbar
aaronmarkham 8c94813
update youtube address
aaronmarkham 25ccaec
use regular colored social buttons
aaronmarkham 29ead68
remove padding to prevent overlap of social icons on high res monitors
aaronmarkham aa906fb
add image padding to social icons
aaronmarkham 9387025
update twitter button
aaronmarkham 4d17a7f
Merge branch 'master' into social_media_update
aaronmarkham 0a6ae47
update images; fix youtube link & contrib social section
aaronmarkham f26ebf2
hide social when colliding with promo
aaronmarkham c8643fc
adding more padding to social images
aaronmarkham 824234f
reduce promo div for social
aaronmarkham 7c8608e
removing height limit to let the social logos get a bit bigger
aaronmarkham bac9781
Merge branch 'master' into social_media_update
aaronmarkham 5881164
Merge branch 'master' into social_media_update
aaronmarkham 5a6bc6c
update image names
aaronmarkham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<div class="container" id="social-container"> | ||
<div class="row"> | ||
<div class="col-lg-offset-10 col-lg-2 col-sm-offset-11 col-sm-1"> | ||
<div class="col-lg-3"> | ||
<a class="main-nav-link social-link" href="https://medium.com/apache-mxnet"><img class="social-logo" src="https://raw.githubusercontent.com/dmlc/web-data/master/mxnet/social/medium.png" alt="medium"/></a> | ||
</div> | ||
<div class="col-lg-3"> | ||
<a class="main-nav-link social-link" href="https://reddit.com/r/mxnet"><img class="social-logo" src="https://raw.githubusercontent.com/dmlc/web-data/master/mxnet/social/reddit.png" alt="reddit"/></a> | ||
</div> | ||
<div class="col-lg-3"> | ||
<a class="main-nav-link social-link" href="https://twitter.com/apachemxnet"><img class="social-logo" src="https://raw.githubusercontent.com/dmlc/web-data/master/mxnet/social/twitter.png" alt="twitter"/></a> | ||
</div> | ||
<div class="col-lg-3"> | ||
<a class="main-nav-link social-link" href="https://www.youtube.com/channel/UCQua2ZAkbr_Shsgfk1LCy6A"><img class="social-logo" src="https://raw.githubusercontent.com/dmlc/web-data/master/mxnet/social/youtube.png" alt="youtube"/></a> | ||
</div> | ||
</div> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole section renders bad, with the logos not aligned properly. Needs some work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started with the community page and hated how ugly that social section was. That's why I added the nav bar. I'll circle back and fix it.
Also I can add higher resolution images. I might need to requestion a 4k monitor 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
I'm sure you can find a manager at AWS that will approve such a request...