This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix for bug #10868: _backward_softsign activation is incorrect #11827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh
anirudh2290
reviewed
Jul 19, 2018
There was a problem hiding this comment.
Thanks a lot for making the change. Please fix lint. Also don't forget to add yourself to https://github.com/apache/incubator-mxnet/blob/master/CONTRIBUTORS.md
src/operator/nn/activation.cc
Outdated
| const NodeAttrs& attrs = n->attrs; | ||
| if (dmlc::get<ActivationParam>(attrs.parsed).act_type == activation::kSoftSign) { |
There was a problem hiding this comment.
nit: cache act_type to avoid repeated calls ..
|
@nswamy @eric-haibin-lin this fixes #10868 . Please take a look. |
haojin2
reviewed
Jul 19, 2018
src/operator/nn/activation.cc
Outdated
| // for ReLU, no need to pass input data. This enables inplace optimization during the | ||
| // forward pass. | ||
| if (dmlc::get<ActivationParam>(attrs.parsed).act_type != activation::kReLU) { | ||
| if (dmlc::get<ActivationParam>(attrs.parsed).act_type != activation::kReLU && | ||
| dmlc::get<ActivationParam>(attrs.parsed).act_type != activation::kSoftSign) { |
There was a problem hiding this comment.
nit: alignment with the line above:
if (dmlc ...
dmlc ...)
|
Good first blood! @samskalicky |
added 6 commits
July 19, 2018 20:13
problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces
anirudh2290
reviewed
Jul 20, 2018
added 14 commits
July 20, 2018 16:04
anirudh2290
approved these changes
Jul 20, 2018
KellenSunderland
pushed a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Jul 21, 2018
…pache#11827) * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces * rerunning the CI build * fixed size checks for when USE_MKLDNN=ON
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…pache#11827) * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces * rerunning the CI build * fixed size checks for when USE_MKLDNN=ON
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem was that softsign was computed using outputs instead of inputs
added inputs to list, and changed what gets passed into softsign calculation
added softsign test to test_activation function
code reviewed by anirudh
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments