Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] Fix subgraph duplicate entry bugs #11767

Merged
merged 1 commit into from
Jul 18, 2018
Merged

[WIP] Fix subgraph duplicate entry bugs #11767

merged 1 commit into from
Jul 18, 2018

Conversation

reminisce
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@reminisce reminisce merged commit 6fe9db2 into apache:subgraph Jul 18, 2018
szha
szha reviewed Jul 18, 2018
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reminisce added a commit that referenced this pull request Aug 4, 2018
@reminisce
Fix duplicate entry bugs (#11767)
6393058
ashokei pushed a commit to NervanaSystems/incubator-mxnet that referenced this pull request Aug 4, 2018
@reminisce @ashokei
Fix duplicate entry bugs (apache#11767)
95c050c
reminisce added a commit to reminisce/mxnet that referenced this pull request Aug 14, 2018
@reminisce
Graph partitioner and subgraph op (apache#11251)
3d44d9f 
Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky
reminisce added a commit to reminisce/mxnet that referenced this pull request Aug 21, 2018
@reminisce
Graph partitioner and subgraph op (apache#11251)
9dff9d2 
Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky
reminisce added a commit to reminisce/mxnet that referenced this pull request Aug 23, 2018
@reminisce
Graph partitioner and subgraph op (apache#11251)
30d0702 
Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky
reminisce added a commit to reminisce/mxnet that referenced this pull request Aug 24, 2018
@reminisce
Graph partitioner and subgraph op (apache#11251)
937d6e3 
Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky
reminisce added a commit to reminisce/mxnet that referenced this pull request Aug 28, 2018
@reminisce
Graph partitioner and subgraph op (apache#11251)
5ab9842 
Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky
reminisce added a commit to reminisce/mxnet that referenced this pull request Aug 29, 2018
@reminisce
Graph partitioner and subgraph op (apache#11251)
84002f1 
Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky
eric-haibin-lin pushed a commit that referenced this pull request Aug 31, 2018
@reminisce @eric-haibin-lin
Subgraph API for integrating accelerators with MXNet (#12157)
a64cf7d 
* Graph partitioner and subgraph op (#11251)

Graph partitioner and subgraph op

Fix duplicate entry bugs (#11767)

Make subgraph var node name unique (#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky

* Clean up

* Clean up

* Clean up

* Change version return type in NDArray

* Clean up

* Add register or get for subgraph prop registry

* Address cr

* Remove unnecessary code

* Handle var version issue in naive engine

* Delete example

* Remove registration of resource request for default subgraph op

* Add doc string

* Improve doc string
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
@reminisce @aaronmarkham
Subgraph API for integrating accelerators with MXNet (apache#12157)
04172ce 
* Graph partitioner and subgraph op (apache#11251)

Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky

* Clean up

* Clean up

* Clean up

* Change version return type in NDArray

* Clean up

* Add register or get for subgraph prop registry

* Address cr

* Remove unnecessary code

* Handle var version issue in naive engine

* Delete example

* Remove registration of resource request for default subgraph op

* Add doc string

* Improve doc string
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@reminisce @anirudh2290
Subgraph API for integrating accelerators with MXNet (apache#12157)
265d253 
* Graph partitioner and subgraph op (apache#11251)

Graph partitioner and subgraph op

Fix duplicate entry bugs (apache#11767)

Make subgraph var node name unique (apache#11876)

[DO NOT REVIEW] Fix bug of eliminating cycles (apache#11907)

* Fix cycle bug

* Fix decycle bug

* Fix comment

[DO NOT REVIEW] Subgraph API (apache#12104)

* Initial commit

* Add unit tests

* Fix lint

* Fix lint

* Clean up

* Add graph partitiong to Bind

* Add property name to graph partitioning c api

* Fix unit test gpu context

* Address cr

* Move subgraph to attrs.subgraphs and fix the example

* Fix lint

* Add var version unit test

* Address cr

* Enable unit test that was flaky

* Clean up

* Clean up

* Clean up

* Change version return type in NDArray

* Clean up

* Add register or get for subgraph prop registry

* Address cr

* Remove unnecessary code

* Handle var version issue in naive engine

* Delete example

* Remove registration of resource request for default subgraph op

* Add doc string

* Improve doc string
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reminisce @szha