-
Notifications
You must be signed in to change notification settings - Fork 6.8k
MXNET-336 [Perl] Major Gluon update for Perl API. #11414
Conversation
@tlby Robert, could you please review this PR. Thanks in advance. |
@marcoabreu Hello there, there's a problem with caffe integration that errors out on every PR recently. Are you aware of this ? Is the fix in works ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retooling work here looks great, and the additions look solid.
av_len = av_len(tempav) + 1; | ||
if(av_len) | ||
{ | ||
$1 = (dim_t *)safemalloc(av_len*sizeof(dim_t)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This use of safemalloc()
may be better as Newxc($1, av_len, dim_t)
. safemalloc()
is not documented in perlapi, I think it just happens to be the default in most perl compilations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for this observation, I'll cleanup safemalloc usage up in future, need to verify that Newxc is present in all perls from 5.14 till 5.28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's been around, at least as far back as v5.8.8.
* MXNET-336 Major Gluon update towards parity with Python's API. Miscellaneous bugfixes and improvements. New Engine API. Module::reshape moved to C++ backend. Examples were updated to work on multi-gpu boxes. * fixing random seed for flaky tests. * removed redundant row. * fixed learning rate.
Description
Major Gluon update towards parity with Python's API.
Miscellaneous bugfixes and improvements.
New Engine API.
Module::reshape moved to C++ backend.
Examples were updated to work on multi-gpu boxes.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Major Gluon update towards parity with Python's API.
Miscellaneous bugfixes and improvements.
New Engine API.
Module::reshape moved to C++ backend.
Examples were updated to work on multi-gpu boxes.
Comments