Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MXNET-336 [Perl] Major Gluon update for Perl API. #11414

Merged
merged 7 commits into from
Jun 30, 2018

Conversation

sergeykolychev
Copy link
Contributor

@sergeykolychev sergeykolychev commented Jun 27, 2018

Description

Major Gluon update towards parity with Python's API.
Miscellaneous bugfixes and improvements.
New Engine API.
Module::reshape moved to C++ backend.
Examples were updated to work on multi-gpu boxes.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Major Gluon update towards parity with Python's API.
Miscellaneous bugfixes and improvements.
New Engine API.
Module::reshape moved to C++ backend.
Examples were updated to work on multi-gpu boxes.

Comments

Major Gluon update towards parity with Python's API.
Miscellaneous bugfixes and improvements.
New Engine API.
Module::reshape moved to C++ backend.
Examples were updated to work on multi-gpu boxes.
@sergeykolychev
Copy link
Contributor Author

@tlby Robert, could you please review this PR. Thanks in advance.

@sergeykolychev
Copy link
Contributor Author

@marcoabreu Hello there, there's a problem with caffe integration that errors out on every PR recently. Are you aware of this ? Is the fix in works ?

Copy link
Contributor

@tlby tlby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retooling work here looks great, and the additions look solid.

av_len = av_len(tempav) + 1;
if(av_len)
{
$1 = (dim_t *)safemalloc(av_len*sizeof(dim_t));
Copy link
Contributor

@tlby tlby Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use of safemalloc() may be better as Newxc($1, av_len, dim_t). safemalloc() is not documented in perlapi, I think it just happens to be the default in most perl compilations.

Copy link
Contributor Author

@sergeykolychev sergeykolychev Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for this observation, I'll cleanup safemalloc usage up in future, need to verify that Newxc is present in all perls from 5.14 till 5.28

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's been around, at least as far back as v5.8.8.

@sergeykolychev sergeykolychev self-assigned this Jun 28, 2018
@sergeykolychev sergeykolychev merged commit cca0883 into apache:master Jun 30, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* MXNET-336
Major Gluon update towards parity with Python's API.
Miscellaneous bugfixes and improvements.
New Engine API.
Module::reshape moved to C++ backend.
Examples were updated to work on multi-gpu boxes.

* fixing random seed for flaky tests.

* removed redundant row.

* fixed learning rate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants