Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix #11353 #11360

Merged
merged 12 commits into from
Jun 25, 2018
Merged

Fix #11353 #11360

merged 12 commits into from
Jun 25, 2018

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jun 22, 2018 •
edited
Loading

Description

fix flaky unit test #11353

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin changed the title WIP Fix #11353 Jun 25, 2018
marcoabreu
marcoabreu approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Could you maybe explain in how far the waitall helps?

@szha szha merged commit 619e4bd into apache:master Jun 25, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@eric-haibin-lin @szha
Fix apache#11353 (apache#11360)
1c7e9b6 
* Update test_gluon_trainer.py

* Update test_gluon_trainer.py

* Update test_gluon_trainer.py

* Update test_gluon_trainer.py

* Update test_gluon_trainer.py

* trigger

* Run 100000 times

* Update test_gluon_trainer.py

* run 10K times

* test_trainer_reset_kv didn't fail for 10K time . 2nd Trigger.

* test_trainer_reset_kv didn't fail for 10K times. 3rd Trigger.

* remove for loop
@eric-haibin-lin eric-haibin-lin deleted the test-flaky branch December 22, 2018 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-haibin-lin @marcoabreu @szha