Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Nightly Tests] Sync with latest Dockerfile changes and Enable KV store test #11358

Merged
merged 3 commits into from
Jun 28, 2018

Conversation

mbaijal
Copy link
Contributor

@mbaijal mbaijal commented Jun 22, 2018

Description

The ubuntu_ccache.sh was renamed to deb_ubuntu_ccache.sh recently
This PR updates the dockerfiles for nightly tests to sync with this change.
Also enabled a KV store single node test as discussed in issue #11289

Changes

  • Enabled KVstore single node nightly test on binaries
  • Changes to two dockerfiles

@@ -91,12 +91,12 @@ try {
}
},
'KVStore_SingleNode: GPU': {
node('mxnetlinux-gpu-p3') {
node('mxnetlinux-gpu-p3-8xlarge') {
ws('workspace/nt-KVStoreTest') {
init_git()
unpack_lib('gpu', mx_lib)
//https://github.com/apache/incubator-mxnet/issues/11289
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment will be outdated after this is merged. remove?

@marcoabreu
Copy link
Contributor

I took the liberty to make the requested changes myself @mbaijal @szha @bhavinthaker . This PR is blocking the nightly tests and should be merged asap.

@mbaijal
Copy link
Contributor Author

mbaijal commented Jun 26, 2018

It cannot be merged unless CI is fixed anyway correct?
Also, I do not want to close the associated github issue till this test has been successfully run on this CI setup once (It has never been tested in this format since we never had a p3.8x)

@marcoabreu
Copy link
Contributor

What do you mean with fixed? I'm not aware of it being broken

@mbaijal
Copy link
Contributor Author

mbaijal commented Jun 26, 2018

I guess I phrased it wrong. Rewording it: the PR has not passed CI (in 8 attempts) due to flaky tests and cannot be merged unless it does.

@marcoabreu
Copy link
Contributor

I can only see 3 failed runs, but alright. Please make sure to retrigger until CI passes.

@marcoabreu marcoabreu self-assigned this Jun 28, 2018
@marcoabreu marcoabreu merged commit e8f52b3 into apache:master Jun 28, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
…re test (apache#11358)

* Sync with latest dockerfile changes and enable KV store test

* Update JenkinsfileForBinaries

* Trigger build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants