Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

R-package requires OpenCV #17282

Open
leezu opened this issue Jan 13, 2020 · 1 comment
Open

R-package requires OpenCV #17282

leezu opened this issue Jan 13, 2020 · 1 comment
Labels

Comments

@leezu
Copy link
Contributor

leezu commented Jan 13, 2020

Description

In #7273 #7389 a mandatory dependency on OpenCV was added to the r package. This breaks the r-package on systems without OpenCV #7273 (comment)).

Further, the link command is not set up correctly so that the Rcpp mxnet.so does not link to opencv, causing undefined symbols in mxnet.so. This causes issues when building libmxnet.so with cmake.

@thirdwing do you plan to fix this or could #7389 be reverted?

@leezu
Copy link
Contributor Author

leezu commented Jan 13, 2020

The linking issue will be fixed as part of #17228

Makevars was missing the following entries:

CXX_STD = CXX11
PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) `pkg-config --libs opencv`
PKG_CFLAGS = `pkg-config --cflags opencv`
PKG_CPPFLAGS = -I../inst/include `pkg-config --cflags opencv` `Rscript -e 'Rcpp:::CxxFlags()'`

The problem of making the OpenCV dependency required instead of optional remains.

leezu added a commit to leezu/mxnet that referenced this issue Jan 13, 2020
leezu added a commit to leezu/mxnet that referenced this issue Jan 14, 2020
leezu added a commit to leezu/mxnet that referenced this issue Jan 14, 2020
leezu added a commit that referenced this issue Jan 14, 2020
…17228)

* Support R-package with cmake build and fix installation instructions

* Fix typo

* Fix callback.R

* Clarify creation of personal R library

* Fix generation of R-package documentation

* Remove unused USE_BLAS variable on CI for make rpkg

* Add cmake build command for get_started/linux/r/*.md pages

* Fix zzz.R swallowing error messages

* Fix R-package/src/Makevars for OpenCV dependency

See #17282
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant