Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bug in NAG Optimizer #15543

Closed
zhanghang1989 opened this issue Jul 15, 2019 · 2 comments · Fixed by #16053
Closed

Bug in NAG Optimizer #15543

zhanghang1989 opened this issue Jul 15, 2019 · 2 comments · Fixed by #16053
Labels
Bug Optimizer

Comments

@zhanghang1989
Copy link
Contributor

zhanghang1989 commented Jul 15, 2019 •
edited
Loading

Current implementation of NAG is wrong.

See this PDF for detail in the equations. nag.pdf

FYI @eric-haibin-lin
@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Bug

@vrakesh
Copy link
Contributor

vrakesh commented Jul 15, 2019

@zhanghang1989 Thanks for reporting this

@mxnet-label-bot add [Optimizer, Bug]

@anirudhacharya anirudhacharya mentioned this issue Aug 31, 2019
Merged
4 tasks
eric-haibin-lin pushed a commit that referenced this issue Sep 11, 2019
@anirudhacharya @eric-haibin-lin
Fixes NAG optimizer #15543 (#16053)
85fe0b4 
* fix update rules

* readable updates in unit test

* mom update
larroy pushed a commit to larroy/mxnet that referenced this issue Sep 28, 2019
@anirudhacharya @larroy
Fixes NAG optimizer apache#15543 (apache#16053)
62dce19 
* fix update rules

* readable updates in unit test

* mom update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes NAG optimizer #15543 anirudhacharya/mxnet
4 participants
@zhanghang1989 @vrakesh @marcoabreu @mxnet-label-bot