Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Julia argmax for NDArray #13786

Closed
iblislin opened this issue Jan 7, 2019 · 1 comment · Fixed by #13871
Closed

Julia argmax for NDArray #13786

iblislin opened this issue Jan 7, 2019 · 1 comment · Fixed by #13871
Assignees
@iblislin
Labels
Julia NDArray

Comments

@iblislin
Copy link
Member

iblislin commented Jan 7, 2019

Ref: dmlc/MXNet.jl#425

Due to C/Cpp's 0-based array index, argmax is broken for NDArray at this moment.
@iblislin iblislin added the Julia label Jan 7, 2019
@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels:

@iblislin iblislin self-assigned this Jan 7, 2019
iblislin added a commit that referenced this issue Jan 14, 2019
@iblislin
julia: fix argmax for NDArray
267e7c2 
- fix 0-based index output to 1-based index

close #13786
@iblislin iblislin mentioned this issue Jan 14, 2019
Merged
iblislin added a commit that referenced this issue Jan 18, 2019
@iblislin
julia: fix argmax for NDArray (#13871)
61847be 
- fix 0-based index output to 1-based index

close #13786
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this issue Feb 16, 2019
@iblislin @stephenrawls
julia: fix argmax for NDArray (apache#13871)
d44ef61 
- fix 0-based index output to 1-based index

close apache#13786
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this issue Jun 23, 2019
@iblislin
julia: fix argmax for NDArray (apache#13871)
be742d9 
- fix 0-based index output to 1-based index

close apache#13786
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iblislin iblislin

Labels
Julia NDArray
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Julia: fix argmax/argmin for NDArray apache/mxnet
2 participants
@iblislin @mxnet-label-bot