* Fix input out of index and rscalar of greater

apache · Jul 4, 2020 · dafb139 · dafb139
1 parent 7bb2a07
commit dafb139
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc b/src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc
@@ -98,7 +98,8 @@ MXNET_REGISTER_API("_npi.greater")
   using namespace runtime;
   const nnvm::Op* op = Op::Get("_npi_greater");
   const nnvm::Op* op_scalar = Op::Get("_npi_greater_scalar");
-  UFuncHelper(args, ret, op, op_scalar, nullptr);
+  const nnvm::Op* op_rscalar = Op::Get("_npi_greater_scalar");
+  UFuncHelper(args, ret, op, op_scalar, op_rscalar);
 });
 
 }  // namespace mxnet
diff --git a/src/api/operator/numpy/np_matrix_op.cc b/src/api/operator/numpy/np_matrix_op.cc
@@ -626,10 +626,11 @@ MXNET_REGISTER_API("_npi.vstack")
   attrs.op = op;
   SetAttrDict<op::NumpyVstackParam>(&attrs);
   int num_outputs = 0;
-  std::vector<NDArray*> inputs;
-  for (int i = 0; i < param.num_args; ++i) {
-    inputs.push_back(args[i].operator mxnet::NDArray*());
+  std::vector<NDArray*> inputs_vec(args.size(), nullptr);
+  for (int i = 0; i < args_size; ++i) {
+    inputs_vec[i] = args[i].operator mxnet::NDArray*();
   }
+  NDArray** inputs = inputs_vec.data();
   auto ndoutputs = Invoke(op, &attrs, param.num_args, &inputs[0], &num_outputs, nullptr);
   *ret = ndoutputs[0];
 });