Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Commit

Permalink
[MXAPPS-581] Straight Dope nightly fixes. (#11934)
Browse files Browse the repository at this point in the history
Enable 3 notebooks that were failing tests after making updates to the
Straight Dope book. We also add pandas required by one of these
notebooks.
  • Loading branch information
vishaalkapoor authored and indhub committed Aug 8, 2018
1 parent 1a222c3 commit c000930
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
5 changes: 5 additions & 0 deletions ci/docker/install/ubuntu_nightly_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,8 @@ apt-get -y install time

# Install for RAT License Check Nightly Test
apt-get install -y subversion maven -y #>/dev/null

# Packages needed for the Straight Dope Nightly tests.
pip2 install pandas
pip3 install pandas

17 changes: 7 additions & 10 deletions tests/nightly/straight_dope/test_notebooks_single_gpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,8 @@ def test_linear_algebra(self):
def test_probability(self):
assert _test_notebook('chapter01_crashcourse/probability')

# TODO(vishaalk): Notebook contains the word 'Warning'. Needs to be updated to a synonym.
#def test_autograd(self):
# assert _test_notebook('chapter01_crashcourse/autograd')
def test_autograd(self):
assert _test_notebook('chapter01_crashcourse/autograd')

# Chapter 2

Expand All @@ -113,9 +112,8 @@ def test_softmax_regression_gluon(self):
def test_regularization_scratch(self):
assert _test_notebook('chapter02_supervised-learning/regularization-scratch')

# TODO(vishaalk): Notebook does not appear to be JSON: '{\n "cells": [\n {\n "cell_type": "m....
#def test_regularization_gluon(self):
# assert _test_notebook('chapter02_supervised-learning/regularization-gluon')
def test_regularization_gluon(self):
assert _test_notebook('chapter02_supervised-learning/regularization-gluon')

def test_perceptron(self):
assert _test_notebook('chapter02_supervised-learning/perceptron')
Expand Down Expand Up @@ -258,9 +256,8 @@ def test_tree_lstm(self):
def test_lds_scratch(self):
assert _test_notebook('chapter12_time-series/lds-scratch')

# TODO(vishaalk): File doesn't appear to be valid JSON.
#def test_issm_scratch(self):
# assert _test_notebook('chapter12_time-series/issm-scratch')
def test_issm_scratch(self):
assert _test_notebook('chapter12_time-series/issm-scratch')

# Chapter 14

Expand All @@ -273,7 +270,7 @@ def test_dcgan(self):
def test_generative_adversarial_networks(self):
assert _test_notebook('chapter14_generative-adversarial-networks/conditional')

# TODO(vishaalk): Notebook does not appear to be valid JSON.
# TODO(vishaalk): Investigate.
#def test_pixel2pixel(self):
# assert _test_notebook('chapter14_generative-adversarial-networks/pixel2pixel')

Expand Down

0 comments on commit c000930

Please sign in to comment.