revert in place diff

apache · Aug 28, 2018 · bea0609 · bea0609
1 parent d875592
commit bea0609
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/executor/attach_op_execs_pass.cc b/src/executor/attach_op_execs_pass.cc
@@ -159,7 +159,7 @@ class StatefulComputeExExecutor : public OpExecutor {
     op_ctx.run_ctx = rctx;
 #if MXNET_USE_MKLDNN == 1
     InvalidateOutputs(out_array, req);
-    CreateDefaultInputs(in_array, in_array_fallback);
+    CreateDefaultInputs(in_array, &in_array_fallback);
     fcompute_(state_, op_ctx, in_array_fallback, req, out_array);
     return;
 #endif
@@ -232,7 +232,7 @@ class FComputeExExecutor : public OpExecutor {
     // TODO(alex): (MXNET-847) Remove this fallback feature after subgraph implemented
     const auto is_mkldnn = Op::GetAttr<bool>("TIsMKLDNN");
     if (!is_mkldnn.get(attrs_.op, false)) {
-      CreateDefaultInputs(in_array, in_array_fallback);
+      CreateDefaultInputs(in_array, &in_array_fallback);
       fcompute_(attrs_, op_ctx, in_array_fallback, req, out_array);
       return;
     }

diff --git a/src/operator/nn/mkldnn/mkldnn_base-inl.h b/src/operator/nn/mkldnn/mkldnn_base-inl.h
@@ -358,12 +358,12 @@ static inline void InvalidateOutputs(const std::vector<NDArray> &arrs,
 
 // TODO(alexzai): (MXNET-856) Remove helper function after subgraph feature added
 static inline void CreateDefaultInputs(const std::vector<NDArray> &arrs,
-                                       const std::vector<NDArray> &out_arrs) {
+                                       std::vector<NDArray> *out_arrs) {
   for (size_t i = 0; i < arrs.size(); ++i) {
     if (arrs[i].IsMKLDNNData())
-      out_arrs[i] = arrs[i].Reorder2Default();
+      out_arrs->emplace_back(arrs[i].Reorder2Default());
     else
-      out_arrs[i] = arrs[i];
+      out_arrs->emplace_back(arrs[i]);
   }
 }