[v1.9.x] stop closing opened libs (#20523)

* stopped closing opened libs * removed return handling from load * missed one *lib Co-authored-by: Skalicky <[email protected]>
apache · Aug 18, 2021 · b5e9ae8 · b5e9ae8
1 parent 524be2f
commit b5e9ae8
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/include/mxnet/c_api.h b/include/mxnet/c_api.h
@@ -233,7 +233,7 @@ MXNET_DLL const char *MXGetLastError();
 /*!
  * \brief Load library dynamically
  * \param path to the library .so file
- * \param 0 for quiet, 1 for verbose
+ * \param verbose 0 for quiet, 1 for verbose
  * \return 0 when success, -1 when failure happens.
  */
 MXNET_DLL int MXLoadLib(const char *path, unsigned verbose);

diff --git a/python/mxnet/library.py b/python/mxnet/library.py
@@ -37,7 +37,7 @@ def load(path, verbose=True):
 
     Returns
     ---------
-    void
+    None
     """
     #check if path exists
     if not os.path.exists(path):

diff --git a/src/c_api/c_api.cc b/src/c_api/c_api.cc
@@ -1514,6 +1514,8 @@ void registerPasses(void *lib, int verbose, mxnet::ext::msgSize_t msgSize,
 /*!
  * \brief Loads dynamic custom library and initializes it
  * \param path library path
+ * \param verbose 0 for quiet, 1 for verbose
+ * \return 0 when success, -1 when failure happens.
  */
 int MXLoadLib(const char *path, unsigned verbose) {
   API_BEGIN();

diff --git a/src/initialize.cc b/src/initialize.cc
@@ -96,10 +96,6 @@ LibraryInitializer::LibraryInitializer()
   install_pthread_atfork_handlers();
 }
 
-LibraryInitializer::~LibraryInitializer() {
-  close_open_libs();
-}
-
 bool LibraryInitializer::lib_is_loaded(const std::string& path) const {
   return loaded_libs.count(path) > 0;
 }

diff --git a/src/initialize.h b/src/initialize.h
@@ -56,7 +56,7 @@ class LibraryInitializer {
    */
   LibraryInitializer();
 
-  ~LibraryInitializer();
+  ~LibraryInitializer() = default;
 
   /**
    * @return true if the current pid doesn't match the one that initialized the library