Address review comments

apache · Dec 14, 2018 · b01106e · b01106e
1 parent e4083db
commit b01106e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/tests/python-pytest/onnx/export/onnx_backend_test.py b/tests/python-pytest/onnx/export/onnx_backend_test.py
@@ -73,7 +73,6 @@
     'test_transpose',
     'test_globalmaxpool',
     'test_globalaveragepool',
-    # enabling partial test cases for matmul
     'test_matmul',
     'test_slice_cpu',
     'test_slice_neg',
@@ -144,8 +143,11 @@
 for std_model_test in STANDARD_MODEL:
     BACKEND_TESTS.include(std_model_test)
 
-BACKEND_TESTS.exclude('.*broadcast.*')
 BACKEND_TESTS.exclude('.*bcast.*')
+# Excluding the following tests because expand and logSoftMax are
+# not implemented in ONNX export. Enabling test_exp and test_log,
+# will include the tests for these operators too, that can lead to
+# 'Op not implemented' failures.
 BACKEND_TESTS.exclude('.*expand.*')
 BACKEND_TESTS.exclude('.*log_softmax.*')
 BACKEND_TESTS.exclude('.*logsoftmax.*')

diff --git a/tests/python-pytest/onnx/import/mxnet_backend_test.py b/tests/python-pytest/onnx/import/mxnet_backend_test.py
@@ -45,8 +45,11 @@
 for std_model_test in test_cases.STANDARD_MODEL:
     BACKEND_TESTS.include(std_model_test)
 
-BACKEND_TESTS.exclude('.*broadcast.*')
 BACKEND_TESTS.exclude('.*bcast.*')
+# Excluding the following tests because expand is not implemented
+# in ONNX import. Enabling test_exp will include the tests for
+# this operator too, that can lead to 'Op not implemented' failures.
+# logsoftmax tests are temporarily excluded.
 BACKEND_TESTS.exclude('.*logsoftmax.*')
 BACKEND_TESTS.exclude('.*expand.*')