[MXAPPS-581] Download notebooks during install.

Moving logic to download the Straight Dope notebooks to the docker image
installation steps.

ci/docker/Dockerfile.build.ubuntu_nightly_gpu

@@ -66,6 +66,9 @@ RUN /work/ubuntu_docs.sh
 COPY install/ubuntu_tutorials.sh /work/
 RUN /work/ubuntu_tutorials.sh
 
+COPY install/ubuntu_straight_dope.sh /work/
+RUN /work/ubuntu_straight_dope.sh
+
 COPY install/ubuntu_nightly_tests.sh /work/
 RUN /work/ubuntu_nightly_tests.sh
 

ci/docker/install/ubuntu_straight_dope.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# build and install are separated so changes to build don't invalidate
+# the whole docker cache for the image
+
+set -ex
+# Download the latest MXNet: The Straight Dope notebooks
+rm -rf /work/mxnet/tests/nightly/straight_dope/straight_dope_book
+git clone https://github.com/zackchase/mxnet-the-straight-dope /work/mxnet/tests/nightly/straight_dope/straight_dope_book

ci/docker/runtime_functions.sh

@@ -881,36 +881,39 @@ nightly_test_javascript() {
 }
 
 # Nightly 'MXNet: The Straight Dope' Single-GPU Tests
-set_up_nightly_straight_dope_tests() {
+nightly_straight_dope_python2_single_gpu_tests() {
     set -ex
     cd /work/mxnet/tests/nightly/straight_dope
-    rm -rf ./straight_dope_book
-    git clone https://github.com/zackchase/mxnet-the-straight-dope straight_dope_book
     export PYTHONPATH=/work/mxnet/python/
-    export MXNET_TEST_KERNEL=${1}
-}
-
-nightly_straight_dope_python2_single_gpu_tests() {
-    set_up_nightly_straight_dope_tests python2
+    export MXNET_TEST_KERNEL=python2
     nosetests-2.7 --with-xunit --xunit-file nosetests_straight_dope_python2_single_gpu.xml \
       test_notebooks_single_gpu.py --nologcapture
 }
 
 nightly_straight_dope_python3_single_gpu_tests() {
-    set_up_nightly_straight_dope_tests python3
+    set -ex
+    cd /work/mxnet/tests/nightly/straight_dope
+    export PYTHONPATH=/work/mxnet/python/
+    export MXNET_TEST_KERNEL=python3
     nosetests-3.4 --with-xunit --xunit-file nosetests_straight_dope_python3_single_gpu.xml \
       test_notebooks_single_gpu.py --nologcapture
 }
 
 # Nightly 'MXNet: The Straight Dope' Multi-GPU Tests
 nightly_straight_dope_python2_multi_gpu_tests() {
-    set_up_nightly_straight_dope_tests python2
+    set -ex
+    cd /work/mxnet/tests/nightly/straight_dope
+    export PYTHONPATH=/work/mxnet/python/
+    export MXNET_TEST_KERNEL=python2
     nosetests-2.7 --with-xunit --xunit-file nosetests_straight_dope_python2_multi_gpu.xml \
       test_notebooks_multi_gpu.py --nologcapture
 }
 
 nightly_straight_dope_python3_multi_gpu_tests() {
-    set_up_nightly_straight_dope_tests python3
+    set -ex
+    cd /work/mxnet/tests/nightly/straight_dope
+    export PYTHONPATH=/work/mxnet/python/
+    export MXNET_TEST_KERNEL=python3
     nosetests-3.4 --with-xunit --xunit-file nosetests_straight_dope_python3_multi_gpu.xml \
       test_notebooks_multi_gpu.py --nologcapture
 }