Prospector checker initial commit (#20684)

ci/docker/install/requirements

@@ -34,8 +34,8 @@ Cython==0.29.24
 
 # Development dependencies
 cpplint==1.3.0
-pylint==2.3.1  # pylint and astroid need to be aligned
-astroid==2.3.3  # pylint and astroid need to be aligned
+pylint<3,>=2.8.3 # pylint and astroid need to be aligned
+astroid<2.9,>=2.8.0  # pylint and astroid need to be aligned
 pytest==6.1.2
 pytest-env==0.6.2
 pytest-cov==2.10.1
@@ -54,3 +54,9 @@ h5py==2.10.0
 
 # Array API Standardization requirements
 hypothesis==6.14.0
+
+# Prospector - Python Static Analysis
+prospector==1.5.1
+
+# pyflakes - passive checker of Python programs
+pyflakes<2.4.0,>=2.2.0

ci/docker/runtime_functions.sh

@@ -703,10 +703,17 @@ sanity_check() {
     set -ex
     sanity_clang
     sanity_license
-    sanity_python
+    sanity_tutorial
+    sanity_python_prospector
     sanity_cpp
 }
 
+sanity_tutorial() {
+    set -ex
+    export DMLC_LOG_STACK_TRACE_DEPTH=100
+    OMP_NUM_THREADS=$(expr $(nproc) / 4) pytest -n 4 tests/tutorials/test_sanity_tutorials.py
+}
+
 sanity_license() {
     set -ex
     tools/license_header.py check
@@ -717,6 +724,21 @@ sanity_cpp() {
     3rdparty/dmlc-core/scripts/lint.py mxnet cpp include src plugin cpp-package tests --exclude_path src/operator/contrib/ctc_include include/onednn
 }
 
+sanity_python_prospector() {
+    set -e
+    set +x
+
+    # Run Prospector
+    python3 -m prospector --profile prospector.yaml | tee prospector-output.txt
+    error_cnt=$(awk '/Messages Found:/{print $NF}' prospector-output.txt)
+    if [ $error_cnt -ne 0 ]; then
+        echo 'Please fix the above Prospector warnings.'
+        rm -rf prospector-output.txt
+        exit 1
+    fi
+    rm -rf prospector-output.txt
+}
+
 sanity_clang() {
     set -e
     set +x
@@ -755,13 +777,6 @@ sanity_clang() {
     exit 1
 }
 
-sanity_python() {
-    set -ex
-    export DMLC_LOG_STACK_TRACE_DEPTH=100
-    python3 -m pylint --rcfile=ci/other/pylintrc --ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
-    OMP_NUM_THREADS=$(expr $(nproc) / 4) pytest -n 4 tests/tutorials/test_sanity_tutorials.py
-}
-
 # Tests libmxnet
 # Parameters:
 # $1 -> mxnet_variant: The variant of the libmxnet.so library