Add comment on correctness of 2nd order grad

apache · Jun 5, 2019 · 745ea66 · 745ea66
1 parent ade77d5
commit 745ea66
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/operator/nn/fully_connected.cc b/src/operator/nn/fully_connected.cc
@@ -179,6 +179,8 @@ struct FullyConnectedGrad {
 std::vector<nnvm::NodeEntry> FullyConnectedBackwardGrad(
     const nnvm::NodePtr& n,
     const std::vector<nnvm::NodeEntry>& ograds) {
+  // Note this is not strictly correct but we don't expect inputs to depend on weights at the
+  // moment. If you find such a case, please contribute a more elaborate implementation.   
   std::vector<nnvm::NodeEntry> ret;
   size_t i = 0;
   for (const auto& x : n->inputs) {