Fail build_windows.py if all retries failed and fix CI sanity checks (#…

…18177)

* Fail build_windows.py if all retries failed

* Fix pylint with unpinned astroid causing CI issues

New version of astroid was pushed to pypi which broke CI as CI didn't use pinned version of astroid before.

ci/build_windows.py

@@ -188,7 +188,10 @@ def windows_build(args):
                 logging.info("Build flavour: {} complete in directory: \"{}\"".format(args.flavour, os.path.abspath(path)))
                 logging.info("Build took {}".format(datetime.timedelta(seconds=int(time.time() - t0))))
                 break
-    windows_package(args)
+    if ret == 0:
+        windows_package(args)
+    else:
+        sys.exit(1)
 
 
 def windows_package(args):

ci/docker/install/requirements

@@ -33,7 +33,8 @@ Cython==0.29.7
 
 # Development dependencies
 cpplint==1.3.0
-pylint==2.3.1; python_version >= '3.0'
+pylint==2.3.1  # pylint and astroid need to be aligned
+astroid==2.3.3  # pylint and astroid need to be aligned
 pytest==5.3.5
 pytest-env==0.6.2
 pytest-cov==2.8.1