Pom file clean up -- moved surefire plugin to parent pom.xml

apache · Jan 9, 2019 · 4eb1936 · 4eb1936
1 parent 7b768a7
commit 4eb1936
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 21 deletions.
diff --git a/scala-package/core/pom.xml b/scala-package/core/pom.xml
@@ -13,6 +13,10 @@
   <artifactId>mxnet-core</artifactId>
   <name>MXNet Scala Package - Core</name>
 
+  <properties>
+    <skipTests>false</skipTests>
+  </properties>
+
   <build>
     <plugins>
       <plugin>
@@ -115,16 +119,6 @@
           </argLine>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.22.0</version>
-        <configuration>
-          <argLine>
-            -Djava.library.path=${project.parent.basedir}/native/target
-          </argLine>
-        </configuration>
-      </plugin>
       <plugin>
         <groupId>org.scalastyle</groupId>
         <artifactId>scalastyle-maven-plugin</artifactId>

diff --git a/scala-package/infer/pom.xml b/scala-package/infer/pom.xml
@@ -10,6 +10,10 @@
     <relativePath>../pom.xml</relativePath>
   </parent>
 
+  <properties>
+    <skipTests>false</skipTests>
+  </properties>
+
   <artifactId>mxnet-infer</artifactId>
   <name>MXNet Scala Package - Inference</name>
 
@@ -30,16 +34,6 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.22.0</version>
-        <configuration>
-          <argLine>
-            -Djava.library.path=${project.parent.basedir}/native/target
-          </argLine>
-        </configuration>
-      </plugin>
       <plugin>
         <groupId>org.scalatest</groupId>
         <artifactId>scalatest-maven-plugin</artifactId>

diff --git a/scala-package/pom.xml b/scala-package/pom.xml
@@ -42,6 +42,7 @@
     <cxx>g++</cxx>
     <dollar>$</dollar>
     <MXNET_DIR>${project.basedir}/..</MXNET_DIR>
+    <skipTests>true</skipTests>
   </properties>
 
   <packaging>pom</packaging>
@@ -228,8 +229,12 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.19</version>
+        <version>2.22.0</version>
         <configuration>
+          <skipTests>${skipTests}</skipTests>
+            <argLine>
+              -Djava.library.path=${project.parent.basedir}/native/target
+            </argLine>
           <useSystemClassLoader>false</useSystemClassLoader>
         </configuration>
       </plugin>